Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops

Alex Elder
2020-05-26T16:48:19Z

On 5/26/20 10:07 AM, Krzysztof Wilczyński wrote:
> Hello Greg,
>
> [...]
>> It's "interesting" how using your new helper doesn't actually make the
>> code smaller. Perhaps it isn't a good helper function?

Helper functions often improve code readability, which is
beneficial even if it doesn't reduce code size or efficiency.

But I won't argue for or against this particular change.
It's OK with me either way.

-Alex

> The idea for the helper was inspired by the comment Dan made to Bjorn
> about Bjorn's change, as per:
>
> https://lore.kernel.org/driverdev-devel/20191016135002.GA24678@kadam/
>
> It looked like a good idea to try to reduce the following:
>
> dev->driver && dev->driver->pm && dev->driver->pm->prepare
>
> Into something more succinct. Albeit, given the feedback from yourself
> and Rafael, I gather that this helper is not really a good addition.
>
> Thank you everyone and sorry for the commotion!
>
> Krzysztof
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev
>