From: refactormyself@gmail.com
To: helgaas@kernel.org
Cc: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>,
bjorn@helgaas.com, linux-pci@vger.kernel.org,
skhan@linuxfoundation.org
Subject: [PATCH 0/8] PCI: Align return value of pcie capability accessors with other accessors
Date: Tue, 9 Jun 2020 17:39:42 +0200 [thread overview]
Message-ID: <20200609153950.8346-1-refactormyself@gmail.com> (raw)
From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
PATCH 1 to 7:
PCIBIOS_ error codes have positive values and they are passed down the
call heirarchy from accessors. For functions which are meant to return
only a negative value on failure, passing on this value is a bug.
To mitigate this, call pcibios_err_to_errno() before passing on return
value from pcie capability accessors call heirarchy. This function
converts any positive PCIBIOS_ error codes to negative non-PCI generic
error values.
PATCH 8:
The pcie capability accessors can return 0, -EINVAL, or any PCIBIOS_ error
code. The pci accessor on the other hand can only return 0 or any PCIBIOS_
error code.This inconsistency among these accessor makes it harder for
callers to check for errors.
Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all pcie
capability accessors.
Bolarinwa Olayemi Saheed (8):
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Align return value of pcie capability accessors with other
accessors
drivers/dma/ioat/init.c | 4 ++--
drivers/infiniband/hw/hfi1/pcie.c | 18 +++++++++++++-----
drivers/pci/access.c | 8 ++++----
drivers/pci/pci.c | 10 ++++++++--
drivers/pci/pcie/aer.c | 12 ++++++++++--
drivers/scsi/smartpqi/smartpqi_init.c | 6 +++++-
6 files changed, 42 insertions(+), 16 deletions(-)
--
2.18.2
next reply other threads:[~2020-06-09 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 15:39 refactormyself [this message]
2020-06-09 15:39 ` [PATCH 1/8] PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes refactormyself
2020-06-09 15:39 ` [PATCH 2/8] " refactormyself
2020-06-09 15:39 ` [PATCH 3/8] " refactormyself
2020-06-11 22:24 ` Bjorn Helgaas
2020-06-09 15:39 ` [PATCH 4/8] " refactormyself
2020-06-09 15:39 ` [PATCH 5/8] " refactormyself
2020-06-09 15:39 ` [PATCH 6/8] " refactormyself
2020-06-11 22:26 ` Bjorn Helgaas
2020-06-09 15:39 ` [PATCH 7/8] " refactormyself
2020-06-11 22:27 ` Bjorn Helgaas
2020-06-09 15:39 ` [PATCH 8/8] PCI: Align return value of pcie capability accessors with other accessors refactormyself
2020-06-11 22:28 ` Bjorn Helgaas
2020-06-11 22:16 ` [PATCH 0/8] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609153950.8346-1-refactormyself@gmail.com \
--to=refactormyself@gmail.com \
--cc=bjorn@helgaas.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).