From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916FBC433E0 for ; Thu, 18 Jun 2020 01:59:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 627D72223F for ; Thu, 18 Jun 2020 01:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592445561; bh=+oQMsV7gJQNLISPtRZwjamRghv+JL9im7YddGrtmLtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HayoIAssKnRwdG7lYXjjKqAykNrOcP4Fwuw9itRm7ek7EheQ7rkUYTROrnMcr5g+u UNoOG0igQi7wHeVFkIyU6Ch27xpRrbxmLCjtRKghFHAFTWO1+wTRr2taoGlyI+QOvB tCByn7eSB8G4FUQGkOIk5WkYveE2UrxyAolZoOWY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731266AbgFRB7T (ORCPT ); Wed, 17 Jun 2020 21:59:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731257AbgFRBYk (ORCPT ); Wed, 17 Jun 2020 21:24:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2F8F221FB; Thu, 18 Jun 2020 01:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443479; bh=+oQMsV7gJQNLISPtRZwjamRghv+JL9im7YddGrtmLtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0zkdEt+1HTasbE4YspKB2hitStQhJ6HFDqGhu4wzSyLVkdxh2w1aRDjXXh3pQZwL/ CHYMNzooOiTSg/J7LUvrxttz96mJvKAYd9uxUQ4nlcV6M8/EcmWw8Z92ZQMja3qAQ7 Pjl6I/6i73IDdescJ2in/X1U++8fCLbYXwGYmkFw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marc Zyngier , Lorenzo Pieralisi , Jingoo Han , Sasha Levin , linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 109/172] PCI: dwc: Fix inner MSI IRQ domain registration Date: Wed, 17 Jun 2020 21:21:15 -0400 Message-Id: <20200618012218.607130-109-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012218.607130-1-sashal@kernel.org> References: <20200618012218.607130-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Marc Zyngier [ Upstream commit 0414b93e78d87ecc24ae1a7e61fe97deb29fa2f4 ] On a system that uses the internal DWC MSI widget, I get this warning from debugfs when CONFIG_GENERIC_IRQ_DEBUGFS is selected: debugfs: File ':soc:pcie@fc000000' in directory 'domains' already present! This is due to the fact that the DWC MSI code tries to register two IRQ domains for the same firmware node, without telling the low level code how to distinguish them (by setting a bus token). This further confuses debugfs which tries to create corresponding files for each domain. Fix it by tagging the inner domain as DOMAIN_BUS_NEXUS, which is the closest thing we have as to "generic MSI". Link: https://lore.kernel.org/r/20200501113921.366597-1-maz@kernel.org Signed-off-by: Marc Zyngier Signed-off-by: Lorenzo Pieralisi Acked-by: Jingoo Han Signed-off-by: Sasha Levin --- drivers/pci/controller/dwc/pcie-designware-host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 6d4ef0101ef6..be62f654c8eb 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -285,6 +285,8 @@ int dw_pcie_allocate_domains(struct pcie_port *pp) return -ENOMEM; } + irq_domain_update_bus_token(pp->irq_domain, DOMAIN_BUS_NEXUS); + pp->msi_domain = pci_msi_create_irq_domain(fwnode, &dw_pcie_msi_domain_info, pp->irq_domain); -- 2.25.1