From: Bjorn Helgaas <helgaas@kernel.org>
To: Flavio Suligoi <f.suligoi@asem.it>
Cc: Tom Joseph <tjoseph@cadence.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] pci: controller: cadence: fix wrong path in comment
Date: Mon, 22 Jun 2020 11:52:55 -0500 [thread overview]
Message-ID: <20200622165255.GA2275961@bjorn-Precision-5520> (raw)
In-Reply-To: <20200622091520.9336-1-f.suligoi@asem.it>
Please use "git log --oneline" to help construct the subject line.
Maybe:
PCI: cadence-ep: Remove obsolete path from comment
On Mon, Jun 22, 2020 at 11:15:20AM +0200, Flavio Suligoi wrote:
> This comment still refers to the old driver pathname,
> when all PCI drivers were located directly under the
> drivers/pci directory.
>
> Anyway the function name itself is enough, so we can
> remove the overabundant path reference.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
I did not ack this. Please don't add acks unless someone does so
explicitly.
> ---
>
> v1: - after the suggestion of Bjorn, remove the whole comment line related to
> the wrong path
> - add: Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index 1c15c8352125..690eefd328ea 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
> cdns_pcie_ep_assert_intx(ep, fn, intx, true);
> /*
> * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
> - * from drivers/pci/dwc/pci-dra7xx.c
> */
> mdelay(1);
> cdns_pcie_ep_assert_intx(ep, fn, intx, false);
> --
> 2.17.1
>
prev parent reply other threads:[~2020-06-22 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 9:15 [PATCH v1 1/1] pci: controller: cadence: fix wrong path in comment Flavio Suligoi
2020-06-22 16:52 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622165255.GA2275961@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=f.suligoi@asem.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox