From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, emamd001@umn.edu, wu000273@umn.edu,
kjlu@umn.edu, mccamant@cs.umn.edu
Subject: Re: [PATCH] PCI: qcom: handle pm_runtime_get_sync failure case
Date: Thu, 2 Jul 2020 11:27:06 +0100 [thread overview]
Message-ID: <20200702102706.GA21978@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200605031643.18171-1-navid.emamdoost@gmail.com>
On Thu, Jun 04, 2020 at 10:16:43PM -0500, Navid Emamdoost wrote:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Navid, I will review and merge Dinghao's version of these patches[1]
since he posted them first, I will drop yours from the PCI patch
queue, thanks anyway for posting them.
Lorenzo
[1] https://patchwork.kernel.org/patch/11559819/
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 138e1a2d21cc..48c434e6e915 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1339,10 +1339,8 @@ static int qcom_pcie_probe(struct platform_device *pdev)
>
> pm_runtime_enable(dev);
> ret = pm_runtime_get_sync(dev);
> - if (ret < 0) {
> - pm_runtime_disable(dev);
> - return ret;
> - }
> + if (ret < 0)
> + goto err_pm_runtime_put;
>
> pci->dev = dev;
> pci->ops = &dw_pcie_ops;
> --
> 2.17.1
>
prev parent reply other threads:[~2020-07-02 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 3:16 [PATCH] PCI: qcom: handle pm_runtime_get_sync failure case Navid Emamdoost
2020-07-02 10:27 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702102706.GA21978@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mccamant@cs.umn.edu \
--cc=navid.emamdoost@gmail.com \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).