From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v1 2/2] x86/PCI: Describe @reg for type1_access_ok()
Date: Mon, 13 Jul 2020 16:02:40 -0500 [thread overview]
Message-ID: <20200713210240.GA273404@bjorn-Precision-5520> (raw)
In-Reply-To: <20200713200338.GF3703480@smile.fi.intel.com>
On Mon, Jul 13, 2020 at 11:03:38PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 13, 2020 at 02:59:07PM -0500, Bjorn Helgaas wrote:
> > On Mon, Jul 13, 2020 at 10:44:37PM +0300, Andy Shevchenko wrote:
> > > Describe missed parameter in documentation of type1_access_ok().
> > > Otherwise we get the following warning:
> >
> > Would you mind including the "make" invocation that runs this
> > checking? I assume it's something like "make C=2
> > arch/x86/pci/intel_mid_pci.o"?
>
> No, it is not sparse, it's a kernel doc validation.
> I guess `make W=1` does it, but I can repeat my command line publicly again :-)
> make W=1 C=1 CF=-D__CHECK_ENDIAN__ -j64
Thanks. "make W=1 arch/x86/pci/" is enough. I would just put this in
the commit log, e.g.,
Otherwise "make W=1 arch/x86/pci/" produces the following warning:
CHECK arch/x86/pci/intel_mid_pci.c
CC arch/x86/pci/intel_mid_pci.o
arch/x86/pci/intel_mid_pci.c:152: warning: Function parameter or member 'reg' not described in 'type1_access_ok'
next prev parent reply other threads:[~2020-07-13 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 19:44 [PATCH v1 1/2] x86/PCI: Get rid of custom x86 model comparison Andy Shevchenko
2020-07-13 19:44 ` [PATCH v1 2/2] x86/PCI: Describe @reg for type1_access_ok() Andy Shevchenko
2020-07-13 19:59 ` Bjorn Helgaas
2020-07-13 20:03 ` Andy Shevchenko
2020-07-13 21:02 ` Bjorn Helgaas [this message]
2020-07-14 9:09 ` Andy Shevchenko
2020-07-13 20:59 ` [NEEDS-REVIEW] [PATCH v1 1/2] x86/PCI: Get rid of custom x86 model comparison Dave Hansen
2020-07-14 9:35 ` Andy Shevchenko
2020-07-13 21:02 ` Bjorn Helgaas
2020-07-14 9:38 ` Andy Shevchenko
2020-07-14 19:02 ` Bjorn Helgaas
2020-07-14 19:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713210240.GA273404@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox