Re: [PATCH v2 2/2] PCI: tegra: Remove PLL power supplies

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2589 bytes --]

On Tue, Jun 23, 2020 at 04:55:28PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The Tegra PCI controller driver doesn't need to control the PLL power
> supplies directly, but rather uses the pads provided by the XUSB pad
> controller, which in turn is responsible for supplying power to the
> PLLs.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/pci/controller/pci-tegra.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Hi Lorenzo,

do you have any comments on this? Can we get this into v5.9?

Thanks,
Thierry

> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 235b456698fc..f87a09d21eb0 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2025,7 +2025,7 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask)
>  		pcie->supplies[i++].supply = "hvdd-pex";
>  		pcie->supplies[i++].supply = "vddio-pexctl-aud";
>  	} else if (of_device_is_compatible(np, "nvidia,tegra210-pcie")) {
> -		pcie->num_supplies = 6;
> +		pcie->num_supplies = 3;
>  
>  		pcie->supplies = devm_kcalloc(pcie->dev, pcie->num_supplies,
>  					      sizeof(*pcie->supplies),
> @@ -2033,14 +2033,11 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask)
>  		if (!pcie->supplies)
>  			return -ENOMEM;
>  
> -		pcie->supplies[i++].supply = "avdd-pll-uerefe";
>  		pcie->supplies[i++].supply = "hvddio-pex";
>  		pcie->supplies[i++].supply = "dvddio-pex";
> -		pcie->supplies[i++].supply = "dvdd-pex-pll";
> -		pcie->supplies[i++].supply = "hvdd-pex-pll-e";
>  		pcie->supplies[i++].supply = "vddio-pex-ctl";
>  	} else if (of_device_is_compatible(np, "nvidia,tegra124-pcie")) {
> -		pcie->num_supplies = 7;
> +		pcie->num_supplies = 4;
>  
>  		pcie->supplies = devm_kcalloc(dev, pcie->num_supplies,
>  					      sizeof(*pcie->supplies),
> @@ -2050,11 +2047,8 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask)
>  
>  		pcie->supplies[i++].supply = "avddio-pex";
>  		pcie->supplies[i++].supply = "dvddio-pex";
> -		pcie->supplies[i++].supply = "avdd-pex-pll";
>  		pcie->supplies[i++].supply = "hvdd-pex";
> -		pcie->supplies[i++].supply = "hvdd-pex-pll-e";
>  		pcie->supplies[i++].supply = "vddio-pex-ctl";
> -		pcie->supplies[i++].supply = "avdd-pll-erefe";
>  	} else if (of_device_is_compatible(np, "nvidia,tegra30-pcie")) {
>  		bool need_pexa = false, need_pexb = false;
>  
> -- 
> 2.27.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]