From: Bjorn Helgaas <helgaas@kernel.org>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, guohanjun@huawei.com
Subject: Re: [PATCH] PCI/ASPM: add missing newline when printing parameter 'policy' by sysfs
Date: Fri, 17 Jul 2020 16:36:09 -0500 [thread overview]
Message-ID: <20200717213609.GA774873@bjorn-Precision-5520> (raw)
In-Reply-To: <1594972765-10404-1-git-send-email-wangxiongfeng2@huawei.com>
On Fri, Jul 17, 2020 at 03:59:25PM +0800, Xiongfeng Wang wrote:
> When I cat ASPM parameter 'policy' by sysfs, it displays as follows.
> It's better to add a newline for easy reading.
>
> [root@localhost ~]# cat /sys/module/pcie_aspm/parameters/policy
> [default] performance powersave powersupersave [root@localhost ~]#
>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Applied to pci/aspm for v5.9, thanks!
> ---
> drivers/pci/pcie/aspm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index b17e5ff..253c30c 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1182,6 +1182,7 @@ static int pcie_aspm_get_policy(char *buffer, const struct kernel_param *kp)
> cnt += sprintf(buffer + cnt, "[%s] ", policy_str[i]);
> else
> cnt += sprintf(buffer + cnt, "%s ", policy_str[i]);
> + cnt += sprintf(buffer + cnt, "\n");
> return cnt;
> }
>
> --
> 1.7.12.4
>
prev parent reply other threads:[~2020-07-17 21:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 7:59 [PATCH] PCI/ASPM: add missing newline when printing parameter 'policy' by sysfs Xiongfeng Wang
2020-07-17 21:36 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717213609.GA774873@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox