From: Bjorn Helgaas <helgaas@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-pci@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Sean Kelley <sean.v.kelley@linux.intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linuxarm@huawei.com, Austin Bolen <Austin.Bolen@dell.com>
Subject: Re: [PATCH v2] PCI/AER: Do not reset the port device status if doing firmware first handling.
Date: Fri, 17 Jul 2020 16:39:35 -0500 [thread overview]
Message-ID: <20200717213935.GA775201@bjorn-Precision-5520> (raw)
In-Reply-To: <20200717200129.GA671299@bjorn-Precision-5520>
On Fri, Jul 17, 2020 at 03:01:29PM -0500, Bjorn Helgaas wrote:
> On Mon, Jun 22, 2020 at 07:35:23PM +0800, Jonathan Cameron wrote:
> > pci_aer_clear_device_status() currently resets the device status
> > (PCI_EXP_DEVSTA) on the downstream port above a device, or the port itself
> > if the port is the reported AER error source. This happens even when error
> > handling is firmware first.
> >
> > Our interpretation is that firmware first handling means that the firmware
> > will deal with clearing all relevant error reporting registers
> > including this one.
>
> ...
> But I think what the _OSC negotiation for AER ownership is relevant,
> and that's what your patch tests, so I think this is the right thing
> to do.
>
> So I applied this as below to pci/error for v5.8, thanks a lot!
Oops, sorry, I meant for v5.9. It doesn't seem to be an urgent bug
fix that we could justify merging for v5.8 after the merge window.
prev parent reply other threads:[~2020-07-17 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 11:35 [PATCH v2] PCI/AER: Do not reset the port device status if doing firmware first handling Jonathan Cameron
2020-07-17 20:01 ` Bjorn Helgaas
2020-07-17 21:39 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717213935.GA775201@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Austin.Bolen@dell.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sean.v.kelley@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox