From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEDCC433E1 for ; Wed, 22 Jul 2020 21:06:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADA5A22B3F for ; Wed, 22 Jul 2020 21:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595451982; bh=0kXFnZ3eGvcksP1/5QGEmr83levSCrnfAw04C9aKAUg=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=ZkWQDPjKSWWKwLxG+uwAdVirV2VEgpnYMcbZOYXuB5eXYy/lmYmS9MSfg5SQkKQMa 68HfJn2aNX7bXCjUuL2Tfie8GVb3ZUTa3jD4gyG5l7TOdwcKvLlxZjBY1wpm1UwUCu jb2DUEUphar6I5GjYdJFi2GgWl98JCiNjMf3OsM8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgGVVGW (ORCPT ); Wed, 22 Jul 2020 17:06:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:45620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgGVVGV (ORCPT ); Wed, 22 Jul 2020 17:06:21 -0400 Received: from localhost (mobile-166-175-191-139.mycingular.net [166.175.191.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87D892071A; Wed, 22 Jul 2020 21:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595451981; bh=0kXFnZ3eGvcksP1/5QGEmr83levSCrnfAw04C9aKAUg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=qCcFLMldUA/lEuy1Bs0znS3D/fRFo80D7/8OMxvC7nOUlNwSzA+1hurh+FLGFEMHy BIKMChOwtV2MdX3ldlZS050UVX51lsrhhhTLy/sQFGZnBVLgFU3pjt+GZi/R3oU1S0 vByHkBAlX67Zki5PkuVfXiMopJA5FFUN9m8EBh44= Date: Wed, 22 Jul 2020 16:06:19 -0500 From: Bjorn Helgaas To: Rob Herring Cc: Bjorn Helgaas , Lorenzo Pieralisi , Fabio Estevam , Gustavo Pimentel , Heiko Stuebner , Hou Zhiqiang , Jingoo Han , Jonathan Hunter , Karthikeyan Mitran , Linus Walleij , Lucas Stach , Marek Vasut , Michal Simek , Murali Karicheri , NXP Linux Team , Pengutronix Kernel Team , Richard Zhu , Ryder Lee , Sascha Hauer , Shawn Guo , Shawn Lin , Thierry Reding , Thomas Petazzoni , Tom Joseph , Will Deacon , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 00/19] PCI: Another round of host clean-ups Message-ID: <20200722210619.GA1313543@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722022514.1283916-1-robh@kernel.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 21, 2020 at 08:24:55PM -0600, Rob Herring wrote: > Here's another round PCI host bridge clean-ups. This one aims to > reduce the amount of duplication in host probe functions by providing > more default initialization of the pci_host_bridge. With the prior > clean-ups, it's now possible to alloc and initialize the pci_host_bridge > struct from DT in one step. > > Patches 2 and 3 drop some pci_host_bridge init. Patches 4-11 clean-up > handling of root bus number and bus ranges. Patches 12 and 13 are cleanups > for Cadence driver. Patches 14 and 15 are clean-ups for rCar driver. Patch > 16 makes missing non-prefetchable region just a warning instead of an > error in order to work with rcar-gen2. Patch 17 converts rcar-gen2 to not > use the arm32 specific PCI setup. Patch 18 updates how the DT resource > parsing is done for all the controller drivers. Any other new controller > drivers will need updating. Patch 19 moves the default IRQ mapping to > the bridge init core code. > > This is based on my previous series of clean-ups[1]. > > Compile tested only. Any testing would be appreciated as I don't have > any of this h/w (well, I have a rock960c, but have not gotten PCIe to work > on it). > > Rob > > [1] https://lore.kernel.org/linux-pci/20200522234832.954484-1-robh@kernel.org/ > > Rob Herring (19): > PCI: versatile: Drop flag PCI_ENABLE_PROC_DOMAINS > PCI: Set default bridge parent device > PCI: Drop unnecessary zeroing of bridge fields > PCI: aardvark: Use pci_is_root_bus() to check if bus is root bus > PCI: designware: Use pci_is_root_bus() to check if bus is root bus > PCI: mobiveil: Use pci_is_root_bus() to check if bus is root bus > PCI: xilinx-nwl: Use pci_is_root_bus() to check if bus is root bus > PCI: xilinx: Use pci_is_root_bus() to check if bus is root bus > PCI: rockchip: Use pci_is_root_bus() to check if bus is root bus > PCI: rcar: Use pci_is_root_bus() to check if bus is root bus > PCI: Move setting pci_host_bridge.busnr out of host drivers > PCI: cadence: Use bridge resources for outbound window setup > PCI: cadence: Remove private bus number and range storage > PCI: rcar: Use devm_pci_alloc_host_bridge() > PCI: rcar: Use struct pci_host_bridge.windows list directly > PCI: of: Reduce missing non-prefetchable memory region to a warning > PCI: rcar-gen2: Convert to use modern host bridge probe functions > PCI: Move DT resource setup into devm_pci_alloc_host_bridge() > PCI: Set bridge map_irq and swizzle_irq to default functions > > .../pci/controller/cadence/pcie-cadence-ep.c | 6 +- > .../controller/cadence/pcie-cadence-host.c | 65 +++---- > drivers/pci/controller/cadence/pcie-cadence.c | 9 +- > drivers/pci/controller/cadence/pcie-cadence.h | 8 +- > drivers/pci/controller/dwc/pci-imx6.c | 2 +- > drivers/pci/controller/dwc/pci-keystone.c | 4 +- > .../pci/controller/dwc/pcie-designware-host.c | 28 +-- > drivers/pci/controller/dwc/pcie-designware.h | 2 - > .../controller/mobiveil/pcie-mobiveil-host.c | 21 +-- > .../pci/controller/mobiveil/pcie-mobiveil.h | 1 - > drivers/pci/controller/pci-aardvark.c | 25 +-- > drivers/pci/controller/pci-ftpci100.c | 10 -- > drivers/pci/controller/pci-host-common.c | 17 +- > drivers/pci/controller/pci-loongson.c | 8 - > drivers/pci/controller/pci-mvebu.c | 4 - > drivers/pci/controller/pci-rcar-gen2.c | 162 +++++------------- > drivers/pci/controller/pci-tegra.c | 10 -- > drivers/pci/controller/pci-v3-semi.c | 12 -- > drivers/pci/controller/pci-versatile.c | 13 +- > drivers/pci/controller/pci-xgene.c | 9 - > drivers/pci/controller/pcie-altera.c | 10 -- > drivers/pci/controller/pcie-brcmstb.c | 9 - > drivers/pci/controller/pcie-iproc-platform.c | 10 +- > drivers/pci/controller/pcie-iproc.c | 3 - > drivers/pci/controller/pcie-mediatek.c | 16 -- > drivers/pci/controller/pcie-rcar-host.c | 73 +------- > drivers/pci/controller/pcie-rockchip-host.c | 24 +-- > drivers/pci/controller/pcie-rockchip.h | 1 - > drivers/pci/controller/pcie-xilinx-nwl.c | 20 +-- > drivers/pci/controller/pcie-xilinx.c | 22 +-- > drivers/pci/of.c | 45 +++-- > drivers/pci/pci.h | 8 + > drivers/pci/probe.c | 7 + > include/linux/pci.h | 12 -- > 34 files changed, 160 insertions(+), 516 deletions(-) Beautiful, thanks for doing all this! Acked-by: Bjorn Helgaas