From: Bjorn Helgaas <helgaas@kernel.org>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Joerg Roedel <joro@8bytes.org>, Lu Baolu <baolu.lu@intel.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] PCI/ATS: PASID and PRI are only enumerated in PF devices.
Date: Thu, 23 Jul 2020 14:30:41 -0500 [thread overview]
Message-ID: <20200723193041.GA1446817@bjorn-Precision-5520> (raw)
In-Reply-To: <20200723173819.GA345408@otc-nc-03>
On Thu, Jul 23, 2020 at 10:38:19AM -0700, Raj, Ashok wrote:
> Hi Bjorn
>
> On Tue, Jul 21, 2020 at 09:54:01AM -0500, Bjorn Helgaas wrote:
> > On Mon, Jul 20, 2020 at 09:43:00AM -0700, Ashok Raj wrote:
> > > PASID and PRI capabilities are only enumerated in PF devices. VF devices
> > > do not enumerate these capabilites. IOMMU drivers also need to enumerate
> > > them before enabling features in the IOMMU. Extending the same support as
> > > PASID feature discovery (pci_pasid_features) for PRI.
> > >
> > > Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> >
> > Hi Ashok,
> >
> > When you update this for the 0-day implicit declaration thing, can you
> > update the subject to say what the patch *does*, as opposed to what it
> > is solving? Also, no need for a period at the end.
>
> Yes, will update and resend. Goofed up a couple things, i'll update those
> as well.
>
> > Does this fix a regression? Is it associated with a commit that we
> > could add as a "Fixes:" tag so we know how far back to try to apply
> > to stable kernels?
>
> Yes,
Does that mean "yes, this fixes a regression"?
> but the iommu files moved location and git fixes tags only generates
> for a few handful of commits and doesn't show the old ones.
Not sure how to interpret the rest of this. I'm happy to include the
SHA1 of the original commit that added the regression, even if the
file has moved since then.
Bjorn
next prev parent reply other threads:[~2020-07-23 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:43 [PATCH] PCI/ATS: PASID and PRI are only enumerated in PF devices Ashok Raj
2020-07-20 20:43 ` kernel test robot
2020-07-21 4:53 ` kernel test robot
2020-07-21 14:54 ` Bjorn Helgaas
2020-07-23 17:38 ` Raj, Ashok
2020-07-23 19:30 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-21 19:44 Ashok Raj
2020-07-21 21:13 Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723193041.GA1446817@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@intel.com \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox