From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
Patrick Volkerding <volkerdi@gmail.com>,
Ben Skeggs <bskeggs@redhat.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/PM: Assume ports without DLL Link Active train links in 100 ms
Date: Thu, 20 Aug 2020 10:13:14 +0200 [thread overview]
Message-ID: <20200820081314.l25cjoehbnvbjbrk@wunner.de> (raw)
In-Reply-To: <20200819130625.12778-1-mika.westerberg@linux.intel.com>
On Wed, Aug 19, 2020 at 04:06:25PM +0300, Mika Westerberg wrote:
> Sec 7.5.3.6 requires such Ports to support DLL Link Active reporting, but
> at least the Intel JHL6240 Thunderbolt 3 Bridge [8086:15c0] and the Intel
> JHL7540 Thunderbolt 3 Bridge [8086:15ea] do not.
[...]
> + * Also do the same for devices that have power management disabled
> + * by their driver and are completely power managed through the
> + * root port power resource instead. This is a special case for
> + * nouveau.
> */
> - if (!pci_is_pcie(dev)) {
> + if (!pci_is_pcie(dev) || !child->pm_cap) {
It sounds like the above-mentioned Thunderbolt controllers are broken,
not the Nvidia cards, so to me (as an outside observer) it would seem
more logical that a quirk for the former is needed. The code comment
suggests that nouveau somehow has a problem, but that doesn't seem to
be the case (IIUC). Also, it's a little ugly to have references to
specific drivers in PCI core code.
Maybe this can be fixed with quirks for the Thunderbolt controllers
which set a flag, and that flag causes the 1000 msec wait to be skipped?
Thanks,
Lukas
next prev parent reply other threads:[~2020-08-20 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 13:06 [PATCH] PCI/PM: Assume ports without DLL Link Active train links in 100 ms Mika Westerberg
2020-08-19 16:58 ` Lyude Paul
2020-08-19 17:20 ` Mika Westerberg
2020-08-20 8:13 ` Lukas Wunner [this message]
2020-08-20 15:36 ` Lyude Paul
2020-08-21 9:32 ` Mika Westerberg
2020-08-21 23:09 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820081314.l25cjoehbnvbjbrk@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=bskeggs@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=kherbst@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mika.westerberg@linux.intel.com \
--cc=volkerdi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).