Re: [PATCH] PCI: Add #defines for max payload size options

[Bjorn Helgaas <helgaas@kernel.org>]

On Mon, Aug 24, 2020 at 04:49:27PM +0000, Gustavo Pimentel wrote:
> On Thu, Aug 20, 2020 at 21:59:42, Bjorn Helgaas <helgaas@kernel.org> 
> wrote:
> 
> > On Thu, Aug 13, 2020 at 04:08:50PM +0200, Gustavo Pimentel wrote:
> > > Add #defines for the max payload size options. No functional change
> > > intended.
> > > 
> > > Cc: Joao Pinto <jpinto@synopsys.com>
> > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > > ---
> > >  include/uapi/linux/pci_regs.h | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
> > > index f970141..db625bd 100644
> > > --- a/include/uapi/linux/pci_regs.h
> > > +++ b/include/uapi/linux/pci_regs.h
> > > @@ -503,6 +503,12 @@
> > >  #define  PCI_EXP_DEVCTL_URRE	0x0008	/* Unsupported Request Reporting En. */
> > >  #define  PCI_EXP_DEVCTL_RELAX_EN 0x0010 /* Enable relaxed ordering */
> > >  #define  PCI_EXP_DEVCTL_PAYLOAD	0x00e0	/* Max_Payload_Size */
> > > +#define  PCI_EXP_DEVCTL_PAYLOAD_128B  0x0000 /* 128 Bytes */
> > > +#define  PCI_EXP_DEVCTL_PAYLOAD_256B  0x0020 /* 256 Bytes */
> > > +#define  PCI_EXP_DEVCTL_PAYLOAD_512B  0x0040 /* 512 Bytes */
> > > +#define  PCI_EXP_DEVCTL_PAYLOAD_1024B 0x0060 /* 1024 Bytes */
> > > +#define  PCI_EXP_DEVCTL_PAYLOAD_2048B 0x0080 /* 2048 Bytes */
> > > +#define  PCI_EXP_DEVCTL_PAYLOAD_4096B 0x00a0 /* 4096 Bytes */
> > 
> > I would apply this if we actually *used* these anywhere, but I'm not
> > sure it's worth adding them just as documentation.
> 
> Hi Bjorn,
> 
> I'll be using that with a driver that I developed. I didn't send the 
> driver yet, because I'm still waiting for a final validation from a 
> colleague that is on vacation. If you want I can include this patch with 
> the driver patch set.

Yes, please include it with the driver.  Thanks!

Bjorn