Re: [PATCH 2/2] pci: fix memleak when calling pci_iomap/unmap()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2346 bytes --]

Hi Yang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on linux/master linus/master v5.9-rc2 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yang-Yingliang/fix-memleak-when-using-pci_iounmap/20200828-143645
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-randconfig-s031-20200828 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-191-g10164920-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   hppa-linux-ld: arch/parisc/lib/iomap.o: in function `pci_iounmap':
>> arch/parisc/lib/iomap.c:498: multiple definition of `pci_iounmap'; lib/pci_iomap.o:lib/pci_iomap.c:141: first defined here

# https://github.com/0day-ci/linux/commit/6a62687154945b449554222ffe875acae4cd1cdb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yang-Yingliang/fix-memleak-when-using-pci_iounmap/20200828-143645
git checkout 6a62687154945b449554222ffe875acae4cd1cdb
vim +498 arch/parisc/lib/iomap.c

^1da177e4c3f415 Linus Torvalds 2005-04-16  492  
^1da177e4c3f415 Linus Torvalds 2005-04-16  493  void ioport_unmap(void __iomem *addr)
^1da177e4c3f415 Linus Torvalds 2005-04-16  494  {
^1da177e4c3f415 Linus Torvalds 2005-04-16  495  	if (!INDIRECT_ADDR(addr)) {
^1da177e4c3f415 Linus Torvalds 2005-04-16  496  		iounmap(addr);
^1da177e4c3f415 Linus Torvalds 2005-04-16  497  	}
^1da177e4c3f415 Linus Torvalds 2005-04-16 @498  }
^1da177e4c3f415 Linus Torvalds 2005-04-16  499  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28162 bytes --]