From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEADC433E2 for ; Wed, 2 Sep 2020 12:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5356B20829 for ; Wed, 2 Sep 2020 12:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599049746; bh=/5zITwQgLMel5YXHYupTFIKYxnlLuiBxHFfhEAM0zfA=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=jdyZtp5H0YsSrRl71kCm14byJgviUzaKJJQZRcPUG+WwHC2cRzy4Faomy6zImN8oD 5z4tuhSB3OaloW28AyI5nkXLINKHqlKgtVKWbWIHw5CJFHmduhBj6ZlCCUdIj+72J0 LzHBtt+p2QHftpe3Fdkrbr7KQyI2bE3eXxFrEQQA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726177AbgIBM3E (ORCPT ); Wed, 2 Sep 2020 08:29:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:51486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgIBM3D (ORCPT ); Wed, 2 Sep 2020 08:29:03 -0400 Received: from localhost (47.sub-72-107-117.myvzw.com [72.107.117.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A87F62083B; Wed, 2 Sep 2020 12:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599049743; bh=/5zITwQgLMel5YXHYupTFIKYxnlLuiBxHFfhEAM0zfA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=BbTPZSuwNhYPSzyKeYXdR2ks3rMVlCPg6Y1GA8H9h86rRYg1Vih7Csu9U/nxJ/lYC TENC8nhd0UiDYOX5RrIeDcOjt57ddMQ+FYTxqkf2fUW99aQdEFMgwbJVe0J9blyW14 V7HlRBi6yEcXCoiDy/37tUpos8rsamYLRKdgQMyQ= Date: Wed, 2 Sep 2020 07:29:01 -0500 From: Bjorn Helgaas To: =?utf-8?B?5ZCz5piK5r6E?= Ricky Cc: "arnd@arndb.de" , "gregkh@linuxfoundation.org" , "ulf.hansson@linaro.org" , "bhelgaas@google.com" , "rui_feng@realsil.com.cn" , "vailbhavgupta40@gamail.com" , "linux-pci@vger.kernel.org" , "puranjay12@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] misc: rtsx: add power saving function and bios guide options Message-ID: <20200902122901.GA241240@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org > > > From: Ricky Wu > > > > > > Added rts5227 rts5249 rts5260 rts5228 power saving functions, > > > added BIOS guide MMC funciton and U_d3_en register support and > > > fixed rts5260 driving parameter > > > > This should be split into small logical pieces. I can't really tell > > what those would be, but just based on the commit message, it could > > be: > > > > 1) Add rts5227 rts5249 rts5260 rts5228 power saving functions > > > > 2) Add BIOS guide MMC function and U_d3_en register support > > > > 3) Fix rts5260 driving parameter > > > > s/funciton/function/ > > > > It looks like 1) *might* be just this: > > > > rts*_force_power_down() > > { > > ... > > rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, D3_DELINK_MODE_EN, > > D3_DELINK_MODE_EN); > > > > That should be a single patch by itself so it's obvious that it's > > doing the same thing to several drivers. > > Ok, I will have a extra patch for all xx_force_power_down() Great, thanks! > > Explain what "BIOS guide MMC function" means. Mention the name of the > > function this adds so we can connect the patch with the commit log. > > > > "BIOS guide MMC function" means, via BIOS setting to know MMC card > support or not It will be helpful if this is in a patch by itself. As far as I know, there's no actual BIOS *call* here, so you must be looking at some setting in the *device* itself, on the assumption that it was done by the BIOS? That sounds like it could become a problem if the device is ever reset or put in a low-power state. For resets, and possibly even a low-power state, BIOS won't be involved, so the setting will be lost, and the device may work differently after the reset than it did before. That sounds undesirable. > > Explain what "U_d3_en" is; that doesn't even appear in the patch. > > I am going to remove U_d3_en from patch description, this mean > D3_DELINK_MODE_EN register OK. Given the size of the patch, I think the commit log is too short to describe what's going on. More details would be helpful. Bjorn