From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B09E1C433E2 for ; Thu, 3 Sep 2020 22:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7171320786 for ; Thu, 3 Sep 2020 22:45:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EnTAgexJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729506AbgICWpJ (ORCPT ); Thu, 3 Sep 2020 18:45:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729318AbgICWpH (ORCPT ); Thu, 3 Sep 2020 18:45:07 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68B9FC061247 for ; Thu, 3 Sep 2020 15:45:06 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id m5so3268084pgj.9 for ; Thu, 03 Sep 2020 15:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eNUX/+cTGqvgJ3/bHzJkiLjPir7L2OtlnI7Fkl+Xb2A=; b=EnTAgexJsxXcgEbYIyXAxzgDAfpWUMxvmgoddQQgsTw/gu1PMimkQi0sFP+vzoRcoR R5cz17bX6mXjaaXhIIENszOU7GVzd7UtV6ivYdntcxzorGKNslOUw1wAcWUJDwdLZcXs t89r3dF6Bm22f/kj6qlw0hvfFybNvnGy7LAoY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eNUX/+cTGqvgJ3/bHzJkiLjPir7L2OtlnI7Fkl+Xb2A=; b=UHCtxbviz6Vmpiok/64Pf2GGkLExS27yLV5yxmfpcJHB1jsQdgkshwwZ1rMmZi8oiK rsseOxRNxLI9ihABJ01XHFofLBz6kamz/k9qxzv44Of77wqIm4BiuDPKNB/givny0h56 r5PMTWsva/+SDlQUyvcZTvP1MQ5i020FMxy5Kvcjx25nP4BaTQv5BU0Vl4kJzoy1Kd8Z tZmkreO8+qof0NfHrJgeLEUA4uQRNLvL+t0mirCV0lXwlfuh8va+/OXD5T8qZTyNS/sJ nmrRYurjK7ERbdvbsNHiROShRUk1OHmIkjV7TogfEo2gmBIKPid4zC2tiPYb+4Y46NkI kzUA== X-Gm-Message-State: AOAM533szV8KTYYzENEL2LJztqrdzZQZJrGmlVjMETOSmot35EoGdV6P oNllhBRUD48xOXSd+R7G4EVC6A== X-Google-Smtp-Source: ABdhPJyNZusftJcT3VvVFgkaB8aDPyaKtOWJ1b5YXcXD0oRJUTHNPVuoSuBrwlfSbjV/D5xOI4z0Ow== X-Received: by 2002:a17:902:7045:: with SMTP id h5mr6014077plt.4.1599173106022; Thu, 03 Sep 2020 15:45:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id bv7sm1885610pjb.55.2020.09.03.15.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:45:05 -0700 (PDT) Date: Thu, 3 Sep 2020 15:45:04 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 23/28] arm64: vdso: disable LTO Message-ID: <202009031544.61133BF@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-24-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-24-samitolvanen@google.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:48PM -0700, Sami Tolvanen wrote: > Disable LTO for the vDSO by filtering out CC_FLAGS_LTO, as there's no > point in using link-time optimization for the small about of C code. > > Signed-off-by: Sami Tolvanen Yup. (And another replacement of the non-functional DISABLE_LTO...) Reviewed-by: Kees Cook -- Kees Cook