Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

gregkh
2020-09-16T19:12:55Z

On Wed, Sep 16, 2020 at 08:32:26AM -0500, Bjorn Helgaas wrote:
> > So is it ok to take this patch now, or does it need to be changed any?
>
> Yes, it's OK with me if you take this patch.
>
> The ASPM hardware feature is designed to work without any driver
> support. It does need to be configured, which involves both the
> device and the upstream bridge, so it should be done by the BIOS or
> the PCI core. There are a few drivers (amdgpu, radeon, hfi1, e1000e,
> iwlegacy, ath10k, ath9k, mt76, rtlwifi, rtw88, and these rts
> cardreader drivers) that do it themselves, incorrectly.
>
> But this particular patch only *reads* the ASPM control registers,
> without writing them, so it shouldn't make anything worse.

Ok, thanks for the review, now queued up.

greg k-h