Re: [PATCH v11 03/11] PCI: brcmstb: Add bcm7278 register info

Rob Herring
2020-09-10T19:22:00Z

On Mon, Aug 24, 2020 at 03:30:16PM -0400, Jim Quinlan wrote:
> From: Jim Quinlan <jquinlan@broadcom.com>
>
> Add in compatibility strings and code for three Broadcom STB chips. Some
> of the register locations, shifts, and masks are different for certain
> chips, requiring the use of different constants based on of_id.
>
> We would like to add the following at this time to the match list but we
> need to wait until the end of this patchset so that everything works.
>
> { .compatible = "brcm,bcm7211-pcie", .data = &generic_cfg },
> { .compatible = "brcm,bcm7278-pcie", .data = &bcm7278_cfg },
> { .compatible = "brcm,bcm7216-pcie", .data = &bcm7278_cfg },
> { .compatible = "brcm,bcm7445-pcie", .data = &generic_cfg },
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 105 +++++++++++++++++++++++---
> 1 file changed, 93 insertions(+), 12 deletions(-)

I think a better abstraction would be to have 2 versions of the 2
functions that need to be different. But as-is is fine.

Acked-by: Rob Herring <robh@kernel.org>