From: Bjorn Helgaas <helgaas@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed
Date: Thu, 10 Sep 2020 14:34:49 -0500 [thread overview]
Message-ID: <20200910193449.GA807725@bjorn-Precision-5520> (raw)
In-Reply-To: <20200909134234.31204-1-yuehaibing@huawei.com>
On Wed, Sep 09, 2020 at 09:42:34PM +0800, YueHaibing wrote:
> This function has been made static, which causes warning:
>
> WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting")
This commit is still on Lorenzo's pci/dwc branch, so he should be able
to squash this fix in.
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 4d105efb5722..3c3a4d1dbc0b 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -508,7 +508,6 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen)
> dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, cap | link_speed);
>
> }
> -EXPORT_SYMBOL_GPL(dw_pcie_link_set_max_speed);
>
> static u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci)
> {
> --
> 2.17.1
>
>
prev parent reply other threads:[~2020-09-10 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 13:42 [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed YueHaibing
2020-09-10 13:54 ` Rob Herring
2020-09-10 19:34 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910193449.GA807725@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox