Re: [PATCH] [-next] PCI: endpoint: Using plain integer as NULL pointer

[Bjorn Helgaas <helgaas@kernel.org>]

On Thu, Sep 17, 2020 at 11:30:27PM +0200, Gustavo Pimentel wrote:
> Fixes warning given by executing "make C=2 drivers/pci/"
> 
> Sparse output:
> CHECK   drivers/pci/endpoint/pci-epc-core.c
>  drivers/pci/endpoint/pci-epc-core.c: note: in included file:
>  ./include/linux/pci-ep-cfs.h:22:16: warning:
>  Using plain integer as NULL pointer
> CHECK   drivers/pci/endpoint/pci-epf-core.c
>  drivers/pci/endpoint/pci-epf-core.c: note: in included file:
>  ./include/linux/pci-ep-cfs.h:31:16: warning:
>  Using plain integer as NULL pointer
> 
> Reported-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>

I like this one.

Applied to pci/misc for v5.10, thanks!

> ---
>  include/linux/pci-ep-cfs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/pci-ep-cfs.h b/include/linux/pci-ep-cfs.h
> index f42b0fd..6628813 100644
> --- a/include/linux/pci-ep-cfs.h
> +++ b/include/linux/pci-ep-cfs.h
> @@ -19,7 +19,7 @@ void pci_ep_cfs_remove_epf_group(struct config_group *group);
>  #else
>  static inline struct config_group *pci_ep_cfs_add_epc_group(const char *name)
>  {
> -	return 0;
> +	return NULL;
>  }
>  
>  static inline void pci_ep_cfs_remove_epc_group(struct config_group *group)
> @@ -28,7 +28,7 @@ static inline void pci_ep_cfs_remove_epc_group(struct config_group *group)
>  
>  static inline struct config_group *pci_ep_cfs_add_epf_group(const char *name)
>  {
> -	return 0;
> +	return NULL;
>  }
>  
>  static inline void pci_ep_cfs_remove_epf_group(struct config_group *group)
> -- 
> 2.7.4
>