From: Bjorn Helgaas <helgaas@kernel.org>
To: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
Joao Pinto <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH] [-next] PCI: DWC: Fix cast truncates bits from constant value
Date: Thu, 17 Sep 2020 16:47:59 -0500 [thread overview]
Message-ID: <20200917214759.GA1741197@bjorn-Precision-5520> (raw)
In-Reply-To: <7743c426ae2c34573d59636d4d6cefaccdb00990.1600378070.git.gustavo.pimentel@synopsys.com>
On Thu, Sep 17, 2020 at 11:28:03PM +0200, Gustavo Pimentel wrote:
> Fixes warning given by executing "make C=2 drivers/pci/"
>
> Sparse output:
> CHECK drivers/pci/controller/dwc/pcie-designware.c
> drivers/pci/controller/dwc/pcie-designware.c:432:52: warning:
> cast truncates bits from constant value (ffffffff7fffffff becomes
> 7fffffff)
>
> Reported-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 3c3a4d1..dcb7108 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -429,7 +429,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index,
> }
>
> dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index);
> - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE);
> + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~0 & ~PCIE_ATU_ENABLE);
But this cure is worse than the disease. If this is the only way to
fix the warning, I think I'd rather see the warning ;) I'm hopeful
there's a nicer way, but I'm not a language lawyer.
> }
>
> int dw_pcie_wait_for_link(struct dw_pcie *pci)
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-09-17 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 21:28 [PATCH] [-next] PCI: DWC: Fix cast truncates bits from constant value Gustavo Pimentel
2020-09-17 21:47 ` Bjorn Helgaas [this message]
2020-09-18 7:15 ` Gustavo Pimentel
2020-09-21 11:30 ` Gustavo Pimentel
2020-09-21 16:36 ` Bjorn Helgaas
2020-09-22 9:57 ` Gustavo Pimentel
-- strict thread matches above, loose matches on Subject: below --
2020-09-22 9:59 Gustavo Pimentel
2020-09-22 16:57 ` Bjorn Helgaas
2020-09-28 11:42 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917214759.GA1741197@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox