From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Fix comparison to bool warning in pci.c
Date: Mon, 28 Sep 2020 17:18:15 -0500 [thread overview]
Message-ID: <20200928221815.GA2501439@bjorn-Precision-5520> (raw)
In-Reply-To: <20200925224555.1752460-1-kw@linux.com>
On Fri, Sep 25, 2020 at 10:45:55PM +0000, Krzysztof Wilczyński wrote:
> Take care about Coccinelle warnings:
>
> drivers/pci/pci.c:6008:6-12: WARNING: Comparison to bool
> drivers/pci/pci.c:6024:7-13: WARNING: Comparison to bool
>
> No change to functionality intended.
>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Applied to pci/misc for v5.10, thanks!
I can't remember why I thought about renaming "decode".
> ---
> drivers/pci/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index e39c5499770f..487e7214743d 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -6005,7 +6005,7 @@ int pci_set_vga_state(struct pci_dev *dev, bool decode,
>
> if (flags & PCI_VGA_STATE_CHANGE_DECODES) {
> pci_read_config_word(dev, PCI_COMMAND, &cmd);
> - if (decode == true)
> + if (decode)
> cmd |= command_bits;
> else
> cmd &= ~command_bits;
> @@ -6021,7 +6021,7 @@ int pci_set_vga_state(struct pci_dev *dev, bool decode,
> if (bridge) {
> pci_read_config_word(bridge, PCI_BRIDGE_CONTROL,
> &cmd);
> - if (decode == true)
> + if (decode)
> cmd |= PCI_BRIDGE_CTL_VGA;
> else
> cmd &= ~PCI_BRIDGE_CTL_VGA;
> --
> 2.28.0
>
prev parent reply other threads:[~2020-09-28 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:45 [PATCH] PCI: Fix comparison to bool warning in pci.c Krzysztof Wilczyński
2020-09-25 22:53 ` Krzysztof Wilczyński
2020-09-28 22:18 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928221815.GA2501439@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox