From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: shpchp: Remove unused assignment to variable rc
Date: Mon, 28 Sep 2020 17:28:03 -0500 [thread overview]
Message-ID: <20200928222803.GA2502380@bjorn-Precision-5520> (raw)
In-Reply-To: <20200923025225.471459-1-kw@linux.com>
On Wed, Sep 23, 2020 at 02:52:25AM +0000, Krzysztof Wilczyński wrote:
> The value of the constant POWER_FAILURE assigned to the variable rc
> after the power fault check is never used for anything within the body
> of the board_added() function and it is also overridden later following
> jump to the err_exit label with the return value from the slot_disable()
> callback.
>
> Since the value of rc is never used in any meaningful way the assignment
> can be removed.
>
> I believe the assignment of constant POWER_FAILURE to the rc variable
> was initially taken from the file drivers/pci/hotplug/cpqphp_ctrl.c and
> then used in the file pci/hotplug/shpchp_ctrl.c (the code base is very
> similar) around the time of the Kernel version 2.6.4-rc1 when the
> support for the Standard Hot Plug was first added, sadly the Git history
> only goes as far as to commit 1da177e4c3f4 ("Linux-2.6.12-rc2").
>
> Related:
> https://elixir.bootlin.com/linux/v2.6.4-rc1/source/drivers/pci/hotplug/shpchp_ctrl.c
> https://elixir.bootlin.com/linux/v2.6.4-rc1/source/drivers/pci/hotplug/cpqphp_ctrl.c
>
> Addresses-Coverity-ID: 1226899 ("Unused value")
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Applied to pci/hotplug for v5.10, thanks!
> ---
> drivers/pci/hotplug/shpchp_ctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/shpchp_ctrl.c b/drivers/pci/hotplug/shpchp_ctrl.c
> index 65502e3f7b4f..6a6705e0cf17 100644
> --- a/drivers/pci/hotplug/shpchp_ctrl.c
> +++ b/drivers/pci/hotplug/shpchp_ctrl.c
> @@ -299,7 +299,6 @@ static int board_added(struct slot *p_slot)
> if (p_slot->status == 0xFF) {
> /* power fault occurred, but it was benign */
> ctrl_dbg(ctrl, "%s: Power fault\n", __func__);
> - rc = POWER_FAILURE;
> p_slot->status = 0;
> goto err_exit;
> }
> --
> 2.28.0
>
prev parent reply other threads:[~2020-09-28 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 2:52 [PATCH] PCI: shpchp: Remove unused assignment to variable rc Krzysztof Wilczyński
2020-09-28 22:28 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928222803.GA2502380@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox