From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8E9C4363D for ; Fri, 2 Oct 2020 11:47:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBBDC20719 for ; Fri, 2 Oct 2020 11:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726010AbgJBLq7 (ORCPT ); Fri, 2 Oct 2020 07:46:59 -0400 Received: from foss.arm.com ([217.140.110.172]:33472 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgJBLq7 (ORCPT ); Fri, 2 Oct 2020 07:46:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 858631063; Fri, 2 Oct 2020 04:46:58 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 50CA73F70D; Fri, 2 Oct 2020 04:46:57 -0700 (PDT) Date: Fri, 2 Oct 2020 12:46:52 +0100 From: Lorenzo Pieralisi To: Liu Shixin Cc: Rob Herring , Bjorn Helgaas , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code Message-ID: <20201002114652.GA23640@e121166-lin.cambridge.arm.com> References: <20200918030829.3946025-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918030829.3946025-1-liushixin2@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Sep 18, 2020 at 11:08:29AM +0800, Liu Shixin wrote: > module_bcma_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Liu Shixin > --- > drivers/pci/controller/pcie-iproc-bcma.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) Applied to pci/iproc, thanks. Lorenzo > diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c > index aa55b064f64d..56b8ee7bf330 100644 > --- a/drivers/pci/controller/pcie-iproc-bcma.c > +++ b/drivers/pci/controller/pcie-iproc-bcma.c > @@ -94,18 +94,7 @@ static struct bcma_driver iproc_pcie_bcma_driver = { > .probe = iproc_pcie_bcma_probe, > .remove = iproc_pcie_bcma_remove, > }; > - > -static int __init iproc_pcie_bcma_init(void) > -{ > - return bcma_driver_register(&iproc_pcie_bcma_driver); > -} > -module_init(iproc_pcie_bcma_init); > - > -static void __exit iproc_pcie_bcma_exit(void) > -{ > - bcma_driver_unregister(&iproc_pcie_bcma_driver); > -} > -module_exit(iproc_pcie_bcma_exit); > +module_bcma_driver(iproc_pcie_bcma_driver); > > MODULE_AUTHOR("Hauke Mehrtens"); > MODULE_DESCRIPTION("Broadcom iProc PCIe BCMA driver"); > -- > 2.25.1 >