From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PCI: loongson: simplify the return expression of loongson_pci_probe()
Date: Fri, 2 Oct 2020 12:57:37 +0100 [thread overview]
Message-ID: <20201002115737.GD23640@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200921131054.92797-1-miaoqinglang@huawei.com>
On Mon, Sep 21, 2020 at 09:10:54PM +0800, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/pci/controller/pci-loongson.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied to pci/loongson, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-loongson.c b/drivers/pci/controller/pci-loongson.c
> index 719c19fe2..48169b1e3 100644
> --- a/drivers/pci/controller/pci-loongson.c
> +++ b/drivers/pci/controller/pci-loongson.c
> @@ -183,7 +183,6 @@ static int loongson_pci_probe(struct platform_device *pdev)
> struct device_node *node = dev->of_node;
> struct pci_host_bridge *bridge;
> struct resource *regs;
> - int err;
>
> if (!node)
> return -ENODEV;
> @@ -222,11 +221,7 @@ static int loongson_pci_probe(struct platform_device *pdev)
> bridge->ops = &loongson_pci_ops;
> bridge->map_irq = loongson_map_irq;
>
> - err = pci_host_probe(bridge);
> - if (err)
> - return err;
> -
> - return 0;
> + return pci_host_probe(bridge);
> }
>
> static struct platform_driver loongson_pci_driver = {
> --
> 2.23.0
>
prev parent reply other threads:[~2020-10-02 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:10 [PATCH -next] PCI: loongson: simplify the return expression of loongson_pci_probe() Qinglang Miao
2020-10-01 14:39 ` Rob Herring
2020-10-02 11:57 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002115737.GD23640@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox