From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867A5C55178 for ; Tue, 27 Oct 2020 16:16:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5545221D7B for ; Tue, 27 Oct 2020 16:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603815410; bh=NEoFtR+3zKcGMsPLbPNWhjiqjlHXguIOoKtXrV+qFy8=; h=Date:From:To:Cc:Subject:List-ID:From; b=1xdsohvrOoizpJcdvuIpPQh6tYYCc8mEdGDbzizbCOJALl+CVNaCTA7GfXp//Mr1I iWzU61bYc+rIdqsoa9EIn0b3pW/xknDCfboP9um9DvBcwn8+tyZ7sPEV6lf9CaQqo1 DOn/YXmTvreRko6C0ivYaXGtUGbu2YvApm545zz0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756113AbgJ0QQq (ORCPT ); Tue, 27 Oct 2020 12:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbgJ0QQj (ORCPT ); Tue, 27 Oct 2020 12:16:39 -0400 Received: from localhost (170.sub-72-107-125.myvzw.com [72.107.125.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D06522263; Tue, 27 Oct 2020 16:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603815398; bh=NEoFtR+3zKcGMsPLbPNWhjiqjlHXguIOoKtXrV+qFy8=; h=Date:From:To:Cc:Subject:From; b=XgaVVIpQKhGdcYR75NvZbrc26f1DGmKmzVTWG651INNfhsd/gHgvcgUku+kr5w/Ut pI5FVslt4Xn9QX6ZNKOHLSDO3EB7d4IxpawaZ4izNkTRynERcWZJbjV4Jzhb9TPYuK 5ItbFM4QjXbra2dr2hIEL0EI5zj5W0EmuyyVggLg= Date: Tue, 27 Oct 2020 11:16:36 -0500 From: Bjorn Helgaas To: Shawn Lin Cc: linux-pci@vger.kernel.org Subject: pcie-rockchip-ep.c coverity issue #1437163 Message-ID: <20201027161636.GA182618@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Shawn, Please take a look at this issue reported by Coverity: 332 static int rockchip_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) 333 { 334 struct rockchip_pcie_ep *ep = epc_get_drvdata(epc); 335 struct rockchip_pcie *rockchip = &ep->rockchip; 336 u16 flags; 337 338 flags = rockchip_pcie_read(rockchip, 339 ROCKCHIP_PCIE_EP_FUNC_BASE(fn) + 340 ROCKCHIP_PCIE_EP_MSI_CTRL_REG); CID 1437163 (#2 of 2): Operands don't affect result (CONSTANT_EXPRESSION_RESULT) result_independent_of_operands: flags & (65536UL /* 1UL << 16 */) is always 0 regardless of the values of its operands. This occurs as the logical operand of !. 341 if (!(flags & ROCKCHIP_PCIE_EP_MSI_CTRL_ME)) 342 return -EINVAL;