Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

Jason Gunthorpe
2020-11-08T23:30:09Z

On Sun, Nov 08, 2020 at 11:47:13PM +0100, Thomas Gleixner wrote:

> OTOH, what's the chance that a guest runs on something which
>
> 1) Does not have X86_FEATURE_HYPERVISOR set in cpuid 1/EDX
>
> and
>
> 2) Cannot be identified as Xen domain
>
> and
>
> 3) Does not have a DMI vendor entry which identifies the
> virtualization solution (we don't use that today, but
> adding that table is trivial enough)
>
> and
>
> 4) Has such an IMS device passed through?
>
> Possible, yes. Likely, no. Do we care?

This is exactly my thinking too. IMS is still very new, if we add some
platform flag to disable it then yes there are broken cases but enough
options for an unlucky user to deal with it:

- Have their VMM set X86_FEATURE_HYPERVISOR
- Updating the VMM to set the global disable flag
- Add some "disable_subdevice_msi" kernel comand line flag in the guest

In exchange we get a much cleaner architecture for the next 10 years..

Jason