From: Bjorn Helgaas <helgaas@kernel.org>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: Remove trailing whitespace
Date: Tue, 3 Nov 2020 15:12:59 -0600 [thread overview]
Message-ID: <20201103211259.GA265488@bjorn-Precision-5520> (raw)
In-Reply-To: <20201102133641.474413-1-luzmaximilian@gmail.com>
On Mon, Nov 02, 2020 at 02:36:41PM +0100, Maximilian Luz wrote:
> Remove trailing whitespace and fix some whitespace inconsitencies while
> at it.
I'm OK with this as long as somebody fixes the
s/inconsitencies/inconsistencies/
above. I assume you've scanned all of drivers/acpi/ for similar
issues so they can all be fixed at once.
This is up to Rafael, of course.
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/acpi/pci_irq.c | 2 +-
> drivers/acpi/pci_link.c | 12 ++++++------
> drivers/acpi/power.c | 4 ++--
> drivers/acpi/processor_perflib.c | 4 ++--
> 4 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index dea8a60e18a4..14ee631cb7cf 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -175,7 +175,7 @@ static int acpi_pci_irq_check_entry(acpi_handle handle, struct pci_dev *dev,
> * configure the IRQ assigned to this slot|dev|pin. The 'source_index'
> * indicates which resource descriptor in the resource template (of
> * the link device) this interrupt is allocated from.
> - *
> + *
> * NOTE: Don't query the Link Device for IRQ information at this time
> * because Link Device enumeration may not have occurred yet
> * (e.g. exists somewhere 'below' this _PRT entry in the ACPI
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index 606da5d77ad3..fb4c5632a232 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -6,8 +6,8 @@
> * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
> * Copyright (C) 2002 Dominik Brodowski <devel@brodo.de>
> *
> - * TBD:
> - * 1. Support more than one IRQ resource entry per link device (index).
> + * TBD:
> + * 1. Support more than one IRQ resource entry per link device (index).
> * 2. Implement start/stop mechanism and use ACPI Bus Driver facilities
> * for IRQ management (e.g. start()->_SRS).
> */
> @@ -249,8 +249,8 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link)
> }
> }
>
> - /*
> - * Query and parse _CRS to get the current IRQ assignment.
> + /*
> + * Query and parse _CRS to get the current IRQ assignment.
> */
>
> status = acpi_walk_resources(link->device->handle, METHOD_NAME__CRS,
> @@ -396,7 +396,7 @@ static int acpi_pci_link_set(struct acpi_pci_link *link, int irq)
> /*
> * "acpi_irq_balance" (default in APIC mode) enables ACPI to use PIC Interrupt
> * Link Devices to move the PIRQs around to minimize sharing.
> - *
> + *
> * "acpi_irq_nobalance" (default in PIC mode) tells ACPI not to move any PIC IRQs
> * that the BIOS has already set to active. This is necessary because
> * ACPI has no automatic means of knowing what ISA IRQs are used. Note that
> @@ -414,7 +414,7 @@ static int acpi_pci_link_set(struct acpi_pci_link *link, int irq)
> *
> * Note that PCI IRQ routers have a list of possible IRQs,
> * which may not include the IRQs this table says are available.
> - *
> + *
> * Since this heuristic can't tell the difference between a link
> * that no device will attach to, vs. a link which may be shared
> * by multiple active devices -- it is not optimal.
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 837b875d075e..9c4c3196cb07 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -13,7 +13,7 @@
> * 1. via "Device Specific (D-State) Control"
> * 2. via "Power Resource Control".
> * The code below deals with ACPI Power Resources control.
> - *
> + *
> * An ACPI "power resource object" represents a software controllable power
> * plane, clock plane, or other resource depended on by a device.
> *
> @@ -690,7 +690,7 @@ int acpi_device_sleep_wake(struct acpi_device *dev,
>
> /*
> * Prepare a wakeup device, two steps (Ref ACPI 2.0:P229):
> - * 1. Power on the power resources required for the wakeup device
> + * 1. Power on the power resources required for the wakeup device
> * 2. Execute _DSW (Device Sleep Wake) or (deprecated in ACPI 3.0) _PSW (Power
> * State Wake) for the device, if present
> */
> diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
> index 5909e8fa4013..f00e66de6c53 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -627,7 +627,7 @@ int acpi_processor_preregister_performance(
> goto err_ret;
>
> /*
> - * Now that we have _PSD data from all CPUs, lets setup P-state
> + * Now that we have _PSD data from all CPUs, lets setup P-state
> * domain info.
> */
> for_each_possible_cpu(i) {
> @@ -693,7 +693,7 @@ int acpi_processor_preregister_performance(
> if (match_pdomain->domain != pdomain->domain)
> continue;
>
> - match_pr->performance->shared_type =
> + match_pr->performance->shared_type =
> pr->performance->shared_type;
> cpumask_copy(match_pr->performance->shared_cpu_map,
> pr->performance->shared_cpu_map);
> --
> 2.29.2
>
next prev parent reply other threads:[~2020-11-03 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 13:36 [PATCH] ACPI: Remove trailing whitespace Maximilian Luz
2020-11-03 21:12 ` Bjorn Helgaas [this message]
2020-11-03 21:30 ` Maximilian Luz
2020-11-04 5:13 ` Joe Perches
2020-11-04 15:48 ` Maximilian Luz
2020-11-04 17:12 ` Joe Perches
2020-11-04 17:20 ` Rafael J. Wysocki
2020-11-04 17:37 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103211259.GA265488@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox