Re: [PATCH v1 1/2] PCI: Disable MSI for Pericom PCIe-USB adapter

Andy Shevchenko
2020-11-06T09:56:34Z

On Thu, Nov 05, 2020 at 08:42:03PM +0000, Ben Dooks wrote:
> On 05/11/2020 18:06, Andy Shevchenko wrote:
> > Pericom PCIe-USB adapter ambiguously advertises MSI, but documentation says
> > "The MSI Function is not implemented on this device." in the chapters 7.3.27,
> > 7.3.29-7.3.31.

Thanks for review.

> > + pci_info(dev, "The MSI Function is not implemented on this device, disabling it\n");
> > + dev->no_msi = 1;
> > +
> > pci_info(dev, "PME# is unreliable, disabling it\n");
> > dev->pme_support = 0;
>
> idea: one pci_info() print of:
>
> pci_info(dev, "PME# is unreliable, MSI not implemented, disabling both\n");

I am not in favour of it. Perhaps I can do #ifdef CONFIG_PCI_MSI for those two.

> > -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme);
> > -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_pme);
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_msi_no_pme);
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_msi_no_pme);

--
With Best Regards,
Andy Shevchenko