From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0AE6C55ABD for ; Mon, 9 Nov 2020 18:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95FCB2067C for ; Mon, 9 Nov 2020 18:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730251AbgKISKq (ORCPT ); Mon, 9 Nov 2020 13:10:46 -0500 Received: from mga11.intel.com ([192.55.52.93]:20845 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729426AbgKISKo (ORCPT ); Mon, 9 Nov 2020 13:10:44 -0500 IronPort-SDR: jliq5B+3ehTwhREM/Mn/PpRYCDSFMOkdT49LbDCg0u0rM7x5CblXbqcMaXwXKf09g0OThMdGy+ qRJ+LiXI+NPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="166337354" X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="166337354" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 10:10:41 -0800 IronPort-SDR: tuCvzS3iY3cpdxhXWsvyXZgcwAFdYuomVJ3Zu2pC/uILoxhmsT+axEq93WFuPDPjeW0G5GEjd+ BZOWkmWRC4Cw== X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="327354691" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.36]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 10:10:41 -0800 Date: Mon, 9 Nov 2020 10:10:39 -0800 From: "Raj, Ashok" To: Thomas Gleixner Cc: Jason Gunthorpe , Dan Williams , "Tian, Kevin" , "Jiang, Dave" , Bjorn Helgaas , "vkoul@kernel.org" , "Dey, Megha" , "maz@kernel.org" , "bhelgaas@google.com" , "alex.williamson@redhat.com" , "Pan, Jacob jun" , "Liu, Yi L" , "Lu, Baolu" , "Kumar, Sanjay K" , "Luck, Tony" , "kwankhede@nvidia.com" , "eric.auger@redhat.com" , "parav@mellanox.com" , "rafael@kernel.org" , "netanelg@mellanox.com" , "shahafs@mellanox.com" , "yan.y.zhao@linux.intel.com" , "pbonzini@redhat.com" , "Ortiz, Samuel" , "Hossain, Mona" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "kvm@vger.kernel.org" , Ashok Raj Subject: Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection Message-ID: <20201109181039.GA15472@otc-nc-03> References: <87y2jaipwu.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2jaipwu.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Nov 09, 2020 at 03:08:17PM +0100, Thomas Gleixner wrote: > On Mon, Nov 09 2020 at 12:14, Thomas Gleixner wrote: > > On Sun, Nov 08 2020 at 15:58, Ashok Raj wrote: > >> On Sun, Nov 08, 2020 at 07:47:24PM +0100, Thomas Gleixner wrote: > >> But for SIOV devices there is no PASID filtering at the remap level since > >> interrupt messages don't carry PASID in the TLP. > > > > Why do we need PASID for VMM integrity? > > > > If the device sends a message then the remap unit will see the requester > > ID of the device and if the message it sends is not > > That made me look at patch 4/17 which adds DEVMSI support to the > remap code: > > > + case X86_IRQ_ALLOC_TYPE_DEV_MSI: > > + irte_prepare_msg(msg, index, sub_handle); > > break; > > It does not setup any requester-id filter in IRTE. How is that supposed > to be correct? > Its missing a set_msi_sid() equivalent for the DEV_MSI type.