From: Christoph Hellwig <hch@infradead.org>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] Expose PCIe SSD Status LED Management DSM in sysfs
Date: Wed, 11 Nov 2020 07:05:28 +0000 [thread overview]
Message-ID: <20201111070528.GA7829@infradead.org> (raw)
In-Reply-To: <20201110153735.58587-1-stuart.w.hayes@gmail.com>
On Tue, Nov 10, 2020 at 09:37:35AM -0600, Stuart Hayes wrote:
> +Date: October 2020
> +Contact: Stuart Hayes <stuart.w.hayes@gmail.com>
> +Description: If the device supports the ACPI _DSM method to control the
> + PCIe SSD LED states, ssdleds_supported_states (read only)
> + will show the LED states that are supported by the _DSM.
> +
> +What: /sys/bus/pci/devices/.../ssdleds_current_state
> +Date: October 2020
> +Contact: Stuart Hayes <stuart.w.hayes@gmail.com>
> +Description: If the device supports the ACPI _DSM method to control the
> + PCIe SSD LED states, ssdleds_current_state will show or set
> + the current LED states that are active.
Is the supported file really required? Doesn't the current_state one
also show which LEDs exist?
> +config PCI_SSDLEDS
> + def_bool y if (ACPI && PCI)
> + depends on PCI && ACPI
We really should not default new code to y.
> + if (dsm_output->status != 0 &&
> + !(dsm_output->status == 4 && dsm_output->function_specific_err == 1)) {
overly longline. But to make this a little more obvious, maybe you
want to
a) switch on dsm_output->status
b) add symbolic names for the magic numbers
next prev parent reply other threads:[~2020-11-11 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:37 [PATCH v2] Expose PCIe SSD Status LED Management DSM in sysfs Stuart Hayes
2020-11-11 7:05 ` Christoph Hellwig [this message]
2020-11-12 4:48 ` Stuart Hayes
2020-11-13 14:14 ` Dan Carpenter
2020-11-13 21:38 ` Bjorn Helgaas
2020-11-13 23:19 ` Greg Kroah-Hartman
2020-11-16 22:25 ` Stuart Hayes
2020-11-17 7:07 ` Greg Kroah-Hartman
2020-11-15 6:38 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111070528.GA7829@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox