From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Zhu Yanjun <yanjunz@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
<linux-rdma@vger.kernel.org>, <rds-devel@oss.oracle.com>,
<linux-pci@vger.kernel.org>, <iommu@lists.linux-foundation.org>
Subject: Re: remove dma_virt_ops v2
Date: Thu, 12 Nov 2020 12:59:35 -0400 [thread overview]
Message-ID: <20201112165935.GA932629@nvidia.com> (raw)
In-Reply-To: <20201106181941.1878556-1-hch@lst.de>
On Fri, Nov 06, 2020 at 07:19:31PM +0100, Christoph Hellwig wrote:
> Hi Jason,
>
> this series switches the RDMA core to opencode the special case of
> devices bypassing the DMA mapping in the RDMA ULPs. The virt ops
> have caused a bit of trouble due to the P2P code node working with
> them due to the fact that we'd do two dma mapping iterations for a
> single I/O, but also are a bit of layering violation and lead to
> more code than necessary.
>
> Tested with nvme-rdma over rxe.
>
> Note that the rds changes are untested, as I could not find any
> simple rds test setup.
>
> Changes since v2:
> - simplify the INFINIBAND_VIRT_DMA dependencies
> - add a ib_uses_virt_dma helper
> - use ib_uses_virt_dma in nvmet-rdma to disable p2p for virt_dma devices
> - use ib_dma_max_seg_size in umem
> - stop using dmapool in rds
>
> Changes since v1:
> - disable software RDMA drivers for highmem configs
> - update the PCI commit logs
Lets give Santosh a little longer for RDS, I've grabbed the precursor
parts to for-next for now:
nvme-rdma: Use ibdev_to_node instead of dereferencing ->dma_device
RDMA: Lift ibdev_to_node from rds to common code
RDMA/core: Remove ib_dma_{alloc,free}_coherent
RDMA/umem: Use ib_dma_max_seg_size instead of dma_get_max_seg_size
RMDA/sw: Don't allow drivers using dma_virt_ops on highmem configs
Will get the rest next week regardless.
Thanks,
Jason
next prev parent reply other threads:[~2020-11-12 16:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 18:19 remove dma_virt_ops v2 Christoph Hellwig
2020-11-06 18:19 ` [PATCH 01/10] RMDA/sw: don't allow drivers using dma_virt_ops on highmem configs Christoph Hellwig
2020-11-06 18:19 ` [PATCH 02/10] RDMA/umem: use ib_dma_max_seg_size instead of dma_get_max_seg_size Christoph Hellwig
2020-11-06 18:19 ` [PATCH 03/10] RDMA: lift ibdev_to_node from rds to common code Christoph Hellwig
2020-11-06 18:19 ` [PATCH 04/10] nvme-rdma: use ibdev_to_node instead of dereferencing ->dma_device Christoph Hellwig
2020-11-06 18:19 ` [PATCH 05/10] rds: stop using dmapool Christoph Hellwig
2020-11-06 18:19 ` [PATCH 06/10] RDMA/core: remove ib_dma_{alloc,free}_coherent Christoph Hellwig
2020-11-06 18:19 ` [PATCH 07/10] RDMA/core: remove use of dma_virt_ops Christoph Hellwig
2020-11-06 18:19 ` [PATCH 08/10] PCI/P2PDMA: Remove the DMA_VIRT_OPS hacks Christoph Hellwig
2020-11-06 18:19 ` [PATCH 09/10] PCI/P2PDMA: Cleanup __pci_p2pdma_map_sg a bit Christoph Hellwig
2020-11-06 18:19 ` [PATCH 10/10] dma-mapping: remove dma_virt_ops Christoph Hellwig
2020-11-12 9:40 ` remove dma_virt_ops v2 Christoph Hellwig
2020-11-12 13:23 ` Jason Gunthorpe
2020-11-12 17:36 ` santosh.shilimkar
2020-11-17 10:50 ` Ka-Cheong Poon
2020-11-17 19:10 ` santosh.shilimkar
2020-11-12 16:59 ` Jason Gunthorpe [this message]
2020-11-12 17:09 ` Christoph Hellwig
2020-11-12 17:39 ` Jason Gunthorpe
2020-11-13 8:50 ` Christoph Hellwig
2020-11-17 14:01 ` Mike Marciniszyn
2020-11-17 19:41 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2020-11-05 7:41 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112165935.GA932629@nvidia.com \
--to=jgg@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).