From: Thierry Reding <thierry.reding@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO
Date: Mon, 16 Nov 2020 18:01:48 +0100 [thread overview]
Message-ID: <20201116170137.GA2587640@ulmo> (raw)
In-Reply-To: <20201116165407.8050-1-sudipm.mukherjee@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Mon, Nov 16, 2020 at 04:54:07PM +0000, Sudip Mukherjee wrote:
> Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code,
> we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then
> doing 'return 0'.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> drivers/pci/controller/pci-tegra.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
This has been proposed multiple times in the past and Bjorn and I have
agreed every time that this is not an improvement, so sorry, but NAK.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-16 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 16:54 [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO Sudip Mukherjee
2020-11-16 17:01 ` Thierry Reding [this message]
2020-11-23 14:51 ` [linux-safety] " Sudip Mukherjee
2020-11-23 15:01 ` Lukas Bulwahn
[not found] <1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>
2017-08-29 13:55 ` Thierry Reding
[not found] ` <20170829141401.GA18389@himanshu-Vostro-3559>
2017-08-29 15:09 ` Thierry Reding
2017-08-30 13:59 ` Bjorn Helgaas
2017-08-30 14:25 ` Thierry Reding
2017-08-30 16:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116170137.GA2587640@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).