From: Christoph Hellwig <hch@infradead.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: Damien.LeMoal@wdc.com, linux-block@vger.kernel.org,
bjorn@helgaas.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] drivers: block: save return value of pci_find_capability() in u8
Date: Mon, 7 Dec 2020 14:52:58 +0000 [thread overview]
Message-ID: <20201207145258.GA16899@infradead.org> (raw)
In-Reply-To: <20201206194300.14221-1-puranjay12@gmail.com>
Can we take a step back? I think in general drivers should not bother
with pci_find_capability. Both mtip32xx and skd want to find out if
the devices are PCIe devices, skd then just prints the link speed for
which we have much better helpers, mtip32xx than messes with DEVCTL
which seems actively dangerous to me.
next prev parent reply other threads:[~2020-12-07 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 19:43 [PATCH] drivers: block: save return value of pci_find_capability() in u8 Puranjay Mohan
2020-12-06 23:08 ` Chaitanya Kulkarni
2020-12-07 1:26 ` Bjorn Helgaas
2020-12-07 1:30 ` Damien Le Moal
2020-12-07 18:38 ` Jens Axboe
2020-12-07 1:48 ` Chaitanya Kulkarni
2020-12-07 16:17 ` Ben Dooks
2020-12-07 2:25 ` Damien Le Moal
2020-12-07 14:52 ` Christoph Hellwig [this message]
2020-12-07 16:04 ` Bjorn Helgaas
2020-12-07 17:53 ` Puranjay Mohan
2020-12-07 18:07 ` Keith Busch
2020-12-07 18:35 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207145258.GA16899@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=bjorn@helgaas.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).