Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Arun Easi <aeasi@marvell.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, Girish Basrur <GBasrur@marvell.com>,
	"Quinn Tran" <qutran@marvell.com>
Subject: [PATCH] PCI/VPD: Remove VPD quirk for QLogic 1077:2261
Date: Fri, 18 Dec 2020 17:04:43 -0800	[thread overview]
Message-ID: <20201219010443.6966-1-aeasi@marvell.com> (raw)

The VPD quirk was added by [0] to avoid a system NMI; this issue
has been long fixed in the HBA firmware. In addition, PCI also has
the logic to check the VPD size [1], so this quirk can be reverted
now. More details in the thread:
    "VPD blacklist of Marvell QLogic 1077/2261" [2].

[0] 0d5370d1d852 ("PCI: Prevent VPD access for QLogic ISP2722")
[1] 104daa71b396 ("PCI: Determine actual VPD size on first access")
[2] https://lore.kernel.org/linux-pci/alpine.LRH.2.21.9999.2012161641230.28924@irv1user01.caveonetworks.com/

Signed-off-by: Arun Easi <aeasi@marvell.com>
CC: stable@vger.kernel.org      # v4.6+
---
 drivers/pci/vpd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
index 7915d10..bd54907 100644
--- a/drivers/pci/vpd.c
+++ b/drivers/pci/vpd.c
@@ -570,7 +570,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_LSI_LOGIC, 0x005d, quirk_blacklist_vpd);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_LSI_LOGIC, 0x005f, quirk_blacklist_vpd);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID,
 		quirk_blacklist_vpd);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_QLOGIC, 0x2261, quirk_blacklist_vpd);
 /*
  * The Amazon Annapurna Labs 0x0031 device id is reused for other non Root Port
  * device types, so the quirk is registered for the PCI_CLASS_BRIDGE_PCI class.
-- 
2.9.5


             reply	other threads:[~2020-12-19  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-19  1:04 Arun Easi [this message]
2021-02-24 23:00 ` [PATCH] PCI/VPD: Remove VPD quirk for QLogic 1077:2261 Arun Easi
2021-02-25 16:31   ` Bjorn Helgaas
2021-02-25 19:32     ` [EXT] " Arun Easi
2021-02-25 19:56       ` Bjorn Helgaas
2021-02-25 20:15         ` Arun Easi
2021-02-25 20:42           ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201219010443.6966-1-aeasi@marvell.com \
    --to=aeasi@marvell.com \
    --cc=GBasrur@marvell.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=qutran@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox