From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 785C4C43331 for ; Wed, 30 Dec 2020 13:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 502C6221FA for ; Wed, 30 Dec 2020 13:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbgL3NHO (ORCPT ); Wed, 30 Dec 2020 08:07:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbgL3NHM (ORCPT ); Wed, 30 Dec 2020 08:07:12 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E217C061799 for ; Wed, 30 Dec 2020 05:06:32 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id r4so8643472pls.11 for ; Wed, 30 Dec 2020 05:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=V/V3abGUfnMv5CHsdNdlkRUJBMfCJ9TBAO/vESN3hYQ=; b=wAa2dvHFwGgJNQ7elnYrvF/ZqfsogeW90VDTFzLVyRLWDYOEAMtupMgwo3u0ZKQvLv unAuDhibgy01aj7eOQv6JAJViDXl2kkSkFMnHlm9J+GnMYMUpt8S4mzDRMt87EcFPjK6 bxbGH6MVClPtGW9KT6lVBjKuo8zED/F5K4XApe9GUsZ1dJqY31HzP0AQENc0h8E6L8mn OwqnqM3CdvkX4gCsTP1XSkvAx9R582j8HH2+yir4GhjwEUeoMSA13AirG10xgCbVxJP9 Xdxk+AuoMJEILWRGhJXjUl5UItwzKlgCPkCciVm8Cdh5Plqro3lsuzCkh2593XX/KJWx C5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V/V3abGUfnMv5CHsdNdlkRUJBMfCJ9TBAO/vESN3hYQ=; b=GywG8AO2WLYLgauePX/rqb17dIbJgwPHvW3pc3J7Uob8RvbjqswugGN2sSazG2vE8a /+7ODokf+/0DXGuSy/vX/kxHioLXmN2fBXjqZ8CV0I8OYJsZXK0jDDxsKim2U37roACw ULXnJkPNGu5Bvb90K+95SYktXW7oiDjTmV67Lgwc/dz0chVPF+6mdbWDa1xNAj/sF6FT UCTNktZooJQPeAuSMc3F7HK8Dv3qZBS3bA6a6Ootutb7sdvrVqzudSkeu59L539L+GQs UL900ASq9NZBrfVqBIimLjXiqCxMVwz7xNqlCwbZUDO3+V3/SFjsIFYVEIyUgffPBCg4 yN4w== X-Gm-Message-State: AOAM532yilwZcp6HUTSctcfbdMePQeJWjfG+zx94Q+cVDmuuh6iaf5z2 QqXP495LKhuJVlBf9D5F13h1 X-Google-Smtp-Source: ABdhPJx5Wu3MEyxVC/56+IfITLUzxBKfwsIkYmXHZu5SNo5HvAxpBMuyxeCBFS3hhVi8+x5SIrykZQ== X-Received: by 2002:a17:90a:1b82:: with SMTP id w2mr8742211pjc.127.1609333591547; Wed, 30 Dec 2020 05:06:31 -0800 (PST) Received: from thinkpad ([2409:4072:6013:d529:8c5c:9ef7:2471:6df4]) by smtp.gmail.com with ESMTPSA id i130sm42257739pfe.94.2020.12.30.05.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Dec 2020 05:06:30 -0800 (PST) Date: Wed, 30 Dec 2020 18:36:18 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Lorenzo Pieralisi , "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pci@vger.kernel.org Subject: Re: [PATCH v2 0/2] PCI: qcom: fixup PCIe support on sm8250 Message-ID: <20201230130618.GD5679@thinkpad> References: <20201230115408.492565-1-dmitry.baryshkov@linaro.org> <20201230123542.GA5679@thinkpad> <20201230124641.GC5679@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Dec 30, 2020 at 03:57:54PM +0300, Dmitry Baryshkov wrote: > On Wed, 30 Dec 2020 at 15:46, Manivannan Sadhasivam > wrote: > > > > On Wed, Dec 30, 2020 at 03:38:12PM +0300, Dmitry Baryshkov wrote: > > > Hi Mani, > > > > > > On Wed, 30 Dec 2020 at 15:35, Manivannan Sadhasivam > > > wrote: > > > > > > > > On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > > > > > SM8250 SoC requires another clock to be up to power up the translation > > > > > unit. Add necessary bindings and driver support. > > > > > > > > > > > > > So what is the exact issue you're facing? > > > > > > IOMMU timeouts for PCIe0 device (WiFi) > > > > > > > Strange. I never observed this issue while testing with onboard QCA6390. Is it > > only happening on v5.11? > > No, I've faced it with 5.10 also. Don't remember about 5.9. Downstream > 4.19 also has this patch. > It well might be that on your board the firmware enables this clock. > However to be on a safe side I think we should enable it too. > Okay, then please remove the optional field and make it as a required one. Thanks, Mani > -- > With best wishes > Dmitry