Re: [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

Andy Shevchenko
2021-02-17T13:49:24Z

On Wed, Feb 17, 2021 at 07:40:14PM +0800, Dejin Zheng wrote:
> On Tue, Feb 16, 2021 at 06:46:01PM +0100, Krzysztof Wilczyński wrote:

...

> > The change simplifies the error handling path, how? A line of two which
> > explains how it has been achieved might help should someone reads the
> > commit message in the future.
> >
> To put it simply, if the driver probe fail, the device-managed function
> mechanism will automatically call pcim_release(), then the pci_free_irq_vectors()
> will be executed. For details, please see the relevant code.

Perhaps as a compromise you may add this short sentence to your commit
messages, like "the freeing resources will take automatically when device
is gone".

--
With Best Regards,
Andy Shevchenko