From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C649C433DB for ; Thu, 25 Feb 2021 20:43:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C244564DDC for ; Thu, 25 Feb 2021 20:43:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbhBYUmv (ORCPT ); Thu, 25 Feb 2021 15:42:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:50222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233804AbhBYUmu (ORCPT ); Thu, 25 Feb 2021 15:42:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA52764DE9; Thu, 25 Feb 2021 20:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614285730; bh=iiDs8faW2I0HRLwaoo8wBw016wts+sR9QwSh9FMAK3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=jvA81V7I7sA0P3Ot2kiHmTtE/3LOzo25eyqhAP94IS4NR3m4Cvup8k2jIjSFkF4UQ PfljIphRmPqkfZTwpuoWwE7Uc0OeYNo7sll64WIv99XlT523yheMNmX0L+9rRHuzXH 7eM4UMuFnRKOxDIKCete4AcybvmvMoKHNIMlFV/kQKN/rhSIXd5XpX0fxc1S4rbHnM 4KTl+F7vToDitSeDN4uB6XpDCBQUw5ojun9i6Vg6jcsUoYJb55cmm9CFGB22eMLqLD S08/RhjVhkM0xNcJltzUvCUQY18CtvylA+v0ct0shmi021q5Bg4j5nNAqvbxIlCCBJ y1ieZU3NvgO0w== Date: Thu, 25 Feb 2021 14:42:08 -0600 From: Bjorn Helgaas To: Arun Easi Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Girish Basrur , Quinn Tran Subject: Re: [EXT] Re: [PATCH] PCI/VPD: Remove VPD quirk for QLogic 1077:2261 Message-ID: <20210225204208.GA29802@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Feb 25, 2021 at 12:15:33PM -0800, Arun Easi wrote: > On Thu, 25 Feb 2021, 11:56am, Bjorn Helgaas wrote: > > On Thu, Feb 25, 2021 at 11:32:28AM -0800, Arun Easi wrote: > > > On Thu, 25 Feb 2021, 8:31am, Bjorn Helgaas wrote: > > > > On Wed, Feb 24, 2021 at 03:00:18PM -0800, Arun Easi wrote: > > > > > On Fri, 18 Dec 2020, 5:04pm, Arun Easi wrote: > > > > > > > > > > > The VPD quirk was added by [0] to avoid a system NMI; this issue > > > > > > has been long fixed in the HBA firmware. In addition, PCI also has > > > > > > the logic to check the VPD size [1], so this quirk can be reverted > > > > > > now. More details in the thread: > > > > > > "VPD blacklist of Marvell QLogic 1077/2261" [2]. > > > > > > > > > > > > [0] 0d5370d1d852 ("PCI: Prevent VPD access for QLogic ISP2722") > > > > > > [1] 104daa71b396 ("PCI: Determine actual VPD size on first access") > > > > > > [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_linux-2Dpci_alpine.LRH.2.21.9999.2012161641230.28924-40irv1user01.caveonetworks.com_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=P-q_Qkt75qFy33SvdD2nAxAyN87eO1d-mFO-lqNOomw&m=Bw8qGbVsETqSibSD8JVMAxZh8BCn1cHuskKjbarfuT8&s=IMvYnIBgaHJkzF2-GgIrGymbRguV287NVLG1_KcP_po&e= > > > > > > > > > > > > Signed-off-by: Arun Easi > > > > > > CC: stable@vger.kernel.org # v4.6+ > > > > > > --- > > > > > > > > > > Wondering if there is something needed from my side. I could not find this > > > > > in the v5.12 list. > > > > > > > > Sorry, I blew it on this one (and other VPD patches from Heiner). > > > > It's too late for v5.12, but I'll try again for v5.13. > > > > > > > > > > No worries. As these are mostly one-liners and straight forward changes, > > > posting during RC is not an option for 5.12 inclusion? > > > > Not unless it's critical or it fixes a bug we introduced during the > > merge window. This doesn't seem like either, but please clarify if it > > is. > > > > From the commit log, it looks like this is just a cleanup with no > > benefit to the user. If that's the case, there's no reason to > > backport to stable either. > > Actually, this fixes the issue that block users from seeing VPD data in > "lspci -vvv" listing. My bad in not stating that well in the commit log. > In retrospect, this was mentioned only in a prior e-mail (link[2] above -- > sorry about our exchange servers mangling the URL and redirecting it via > proofpoint). > > I can re-send the patch to correctly reflect it as a fix. Something like: > > Subject: "PCI/VPD: Fix blocking of VPD data in lspci for QLogic 1077:2261" Yes, that would be useful :) The commit log needs to explain why the patch should be merged. Bjorn