Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

Leon Romanovsky
2021-03-19T16:25:05Z

On Fri, Mar 19, 2021 at 10:57:11AM -0500, Bjorn Helgaas wrote:
> On Fri, Mar 19, 2021 at 02:59:47PM +0200, Leon Romanovsky wrote:
> > On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult wrote:
> > > On 18.03.21 18:22, Leon Romanovsky wrote:
> > >
> > > > Which email client do you use? Your responses are grouped as
> > > > one huge block without any chance to respond to you on specific
> > > > point or answer to your question.
> > >
> > > I'm reading this thread in Tbird, and threading / quoting all
> > > looks nice.
> >
> > I'm not talking about threading or quoting but about response
> > itself. See it here
> > https://lore.kernel.org/lkml/20210318103935.2ec32302@omen.home.shazbot.org/
> > Alex's response is one big chunk without any separations to
> > paragraphs.
>
> Don't make this harder than it needs to be. I think it's totally
> acceptable to just split Alex's text where you need to respond. For
> example, Alex wrote this:
>
> vfio-pci uses the internal kernel API, ie. the variants of
> pci_reset_function(), which is the same interface used by the existing
> sysfs reset mechanism. This proposed configuration of the reset method
> would affect any driver using that same core infrastructure and from my
> perspective that's really the goal. ...
>
> If I wanted to respond to the first sentence, I would just do this:
>
> aw> vfio-pci uses the internal kernel API, ie. the variants of
> aw> pci_reset_function(), which is the same interface used by the existing
> aw> sysfs reset mechanism.
>
> I would write my response to the above here. The rest of the quote
> continues on below. If the rest of Alex's message isn't relevant to
> my response, I would remove it completely.
>
> aw> This proposed configuration of the reset method
> aw> would affect any driver using that same core infrastructure and from my
> aw> perspective that's really the goal. ...
>
> Bjorn

Thanks Bjorn, you presented me how to respond on such messages, however
I was more afraid if my setup needs some adjustments and it is only me
who sees it as one chunk.

Thanks