From: Bjorn Helgaas <helgaas@kernel.org>
To: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"ameynarkhede03@gmail.com" <ameynarkhede03@gmail.com>,
Alay Shah <alay.shah@nutanix.com>,
Suresh Gumpula <suresh.gumpula@nutanix.com>
Subject: Re: [PATCH] PCI: Delay after FLR of Intel DC P4510 NVMe
Date: Fri, 9 Apr 2021 11:46:12 -0500 [thread overview]
Message-ID: <20210409164612.GA2037722@bjorn-Precision-5520> (raw)
In-Reply-To: <20210408190521.16897-1-raphael.norwitz@nutanix.com>
On Thu, Apr 08, 2021 at 07:05:27PM +0000, Raphael Norwitz wrote:
> Like the Intel DC P3700 NVMe, the Intel P4510 NVMe exhibits a timeout
> failure when the driver tries to interact with the device to soon after
> an FLR. The same reset quirk the P3700 uses also resolves the failure
> for the P4510, so this change introduces the same reset quirk for the
> P4510.
>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Alay Shah <alay.shah@nutanix.com>
> Signed-off-by: Suresh Gumpula <suresh.gumpula@nutanix.com>
> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Applied to pci/virtualization for v5.13, thanks!
> ---
> drivers/pci/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 653660e3ba9e..5a8c059b848d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3922,6 +3922,7 @@ static const struct pci_dev_reset_methods pci_dev_reset_methods[] = {
> reset_ivb_igd },
> { PCI_VENDOR_ID_SAMSUNG, 0xa804, nvme_disable_and_flr },
> { PCI_VENDOR_ID_INTEL, 0x0953, delay_250ms_after_flr },
> + { PCI_VENDOR_ID_INTEL, 0x0a54, delay_250ms_after_flr },
> { PCI_VENDOR_ID_CHELSIO, PCI_ANY_ID,
> reset_chelsio_generic_dev },
> { 0 }
> --
> 2.20.1
prev parent reply other threads:[~2021-04-09 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 19:05 [PATCH] PCI: Delay after FLR of Intel DC P4510 NVMe Raphael Norwitz
2021-04-09 16:46 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409164612.GA2037722@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=alay.shah@nutanix.com \
--cc=alex.williamson@redhat.com \
--cc=ameynarkhede03@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=raphael.norwitz@nutanix.com \
--cc=suresh.gumpula@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox