From: Alex Williamson <alex.williamson@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shanker R Donthineni <sdonthineni@nvidia.com>,
Sinan Kaya <okaya@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Vikram Sethi <vsethi@nvidia.com>
Subject: Re: [PATCH 1/1] PCI: Add pci reset quirk for Nvidia GPUs
Date: Mon, 26 Apr 2021 13:15:38 -0600 [thread overview]
Message-ID: <20210426131538.0b69c69b@redhat.com> (raw)
In-Reply-To: <20210426181943.GA1418150@infradead.org>
On Mon, 26 Apr 2021 19:19:43 +0100
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Apr 23, 2021 at 04:45:15PM -0500, Shanker R Donthineni wrote:
> > > specific platforms (embedded device?), and the failure mode of the SBR.
> > These are not plug-in PCIe GPU cards, will exist on upcoming
> > server baseboards. Triggering SBR without firmware notification
>
> Please submit the quirks together with the actual support for the GPUs
> in the nouveau driver, as they are completely useless without that.
My default assumption would be that this resolves an issue with
assigning this device to a userspace or VM driver through vfio-pci, as
most in-kernel drivers don't make use of this interface themselves;
they often know more device specific ways to re-initialize hardware.
This reset path is also trivially accessible through pci-sysfs. I
don't expect nouveau would have much use for this even if it did
include support for these devices. Thanks,
Alex
next prev parent reply other threads:[~2021-04-26 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 14:54 [PATCH 1/1] PCI: Add pci reset quirk for Nvidia GPUs Shanker Donthineni
2021-04-23 15:12 ` Sinan Kaya
2021-04-23 15:37 ` Alex Williamson
2021-04-23 21:45 ` Shanker R Donthineni
2021-04-26 18:19 ` Christoph Hellwig
2021-04-26 19:15 ` Alex Williamson [this message]
2021-04-26 19:02 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426131538.0b69c69b@redhat.com \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).