Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Logan Gunthorpe <logang@deltatee.com>,
	Joe Perches <joe@perches.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Tyrel Datwyler <tyreld@linux.ibm.com>,
	Russell Currey <ruscur@russell.cc>,
	Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Xiongfeng Wang <wangxiongfeng2@huawei.com>,
	linux-pci@vger.kernel.org
Subject: [PATCH v3 13/14] PCI/sysfs: Add missing trailing newline to devspec_show()
Date: Tue, 18 May 2021 03:41:08 +0000	[thread overview]
Message-ID: <20210518034109.158450-13-kw@linux.com> (raw)
In-Reply-To: <20210518034109.158450-1-kw@linux.com>

At the moment, when the value of the "devspec" sysfs object is read from
the user space there will be no newline present, and the utilities such
as the "cat" command won't display the result of the read correctly in
a shell, as the trailing newline is currently missing.

To fix this, append a newline character in the show() function.

Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
---
Changes in v2:
  None.
Changes in v3:
  Added Logan Gunthorpe's "Reviewed-by".

 drivers/pci/pci-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index beb8d1f4fafe..5d63df7c1820 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -537,7 +537,7 @@ static ssize_t devspec_show(struct device *dev,
 
 	if (np == NULL)
 		return 0;
-	return sysfs_emit(buf, "%pOF", np);
+	return sysfs_emit(buf, "%pOF\n", np);
 }
 static DEVICE_ATTR_RO(devspec);
 #endif
-- 
2.31.1


  parent reply	other threads:[~2021-05-18  3:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  3:40 [PATCH v3 01/14] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions Krzysztof Wilczyński
2021-05-18  3:40 ` [PATCH v3 02/14] PCI/AER: " Krzysztof Wilczyński
2021-05-18  3:40 ` [PATCH v3 03/14] PCI: " Krzysztof Wilczyński
2021-05-24 21:14   ` Bjorn Helgaas
2021-05-24 21:19     ` Bjorn Helgaas
2021-05-25 10:32       ` Krzysztof Wilczyński
2021-05-25 16:07         ` Logan Gunthorpe
2021-05-18  3:40 ` [PATCH v3 04/14] PCI/MSI: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 05/14] PCI/IOV: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 06/14] PCI/P2PDMA: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 07/14] PCI/ASPM: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 08/14] PCI: switchtec: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 09/14] PCI: rpadlpar: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 10/14] PCI: hotplug: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 11/14] PCI: shpchp: " Krzysztof Wilczyński
2021-05-18  3:41 ` [PATCH v3 12/14] PCI: Fix trailing newline handling of resource_alignment_param Krzysztof Wilczyński
2021-05-21 15:14   ` Krzysztof Wilczyński
2021-05-21 15:34     ` Logan Gunthorpe
2021-05-21 17:19     ` Greg Kroah-Hartman
2021-05-25 10:29       ` Krzysztof Wilczyński
2021-05-18  3:41 ` Krzysztof Wilczyński [this message]
2021-05-18  3:41 ` [PATCH v3 14/14] PCI/sysfs: Only show value when driver_override is not NULL Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210518034109.158450-13-kw@linux.com \
    --to=kw@linux.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=joe@perches.com \
    --cc=kurt.schwemmer@microsemi.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=mpe@ellerman.id.au \
    --cc=oohall@gmail.com \
    --cc=paulus@samba.org \
    --cc=ruscur@russell.cc \
    --cc=tyreld@linux.ibm.com \
    --cc=vidyas@nvidia.com \
    --cc=wangxiongfeng2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox