From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30148C43461 for ; Thu, 20 May 2021 18:03:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07F1F611AB for ; Thu, 20 May 2021 18:03:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233254AbhETSFH (ORCPT ); Thu, 20 May 2021 14:05:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbhETSFH (ORCPT ); Thu, 20 May 2021 14:05:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E95760FF1; Thu, 20 May 2021 18:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621533825; bh=+S8gvzrrVIm9MmYR5IHUp56ZCZSVIkWr11OHTYVVHjw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QBltvNlp1cuGHicXMTZJMAwd56LlDbbW14zoq4ivEXNwFrQHR/GlRO+cpnSVEARgn /CNpJcY/rFmqoYsYMXgtBsK5LZyfiiDnUTyhkeyI6d9qHgke9NrgTIC2pD+NwCFOlf UTRA7rdArULfg3fwozgPV7jcNMqESB1EXgB4XZ9VWLVOP0PEuV1bOUgZ6ODCrQLetE 39+TYx7RRWm217PQ6ywAQ3Fb3D3idiPAdkw+0Fjb7eP5rCxpiemMwkpx2tYQvHq75v 97MJtq79ZQf9E4CDymZbyGnkUNLkHNx0MF3+xCitb9JOcXg5ZTt2ojckMc20UomZsd dDyDERAsBCaXA== Date: Thu, 20 May 2021 12:03:43 -0600 From: Keith Busch To: "Deucher, Alexander" Cc: Bjorn Helgaas , "Liang, Prike" , "linux-pci@vger.kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "stable@vger.kernel.org" , "S-k, Shyam-sundar" , Chaitanya Kulkarni , "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH v5 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt Message-ID: <20210520180343.GA3783@C02WT3WMHTD6> References: <20210520165848.GA324094@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, May 20, 2021 at 05:40:54PM +0000, Deucher, Alexander wrote: > It doesn't really have anything to do with PCI. The PCI link is just a proxy > for specific AMD platforms. It's platform firmware behavior we are catering > to. This was originally posted as an nvme quirk, but during the review it > was recommended to move the quirk into PCI because the quirk is not specific > a particular NVMe device, but rather a set of AMD platforms. Lots of other > platforms seems to do similar things in the nvme driver based on ACPI or DMI > flags, etc. On our hardware this nvme flag is required for all cezanne and > renoir platforms. The quirk was initially presented as specific to the pci root. Does it make more sense for nvme to recognize the limitation from querying a different platform component instead of the pci bus?