From: Christoph Hellwig <hch@lst.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Koba Ko <koba.ko@canonical.com>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme <linux-nvme@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Henrik Juul Hansen <hjhansen2020@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss.
Date: Wed, 26 May 2021 16:28:09 +0200 [thread overview]
Message-ID: <20210526142809.GA32077@lst.de> (raw)
In-Reply-To: <CAAd53p4f2ZFsVRv-Q9maPBSD_uGjj7FoYKYy9MGjBPc6chk_1Q@mail.gmail.com>
On Wed, May 26, 2021 at 10:21:59PM +0800, Kai-Heng Feng wrote:
> To be fair, resuming the NVMe from D3hot is much slower than keep it
> at D0, which gives us a faster s2idle resume time. And now AMD also
> requires s2idle on their latest laptops.
We'd much prefer to use it, but due to the broken platforms we can't
unfortunately.
> And it's more like NVMe controllers don't respect PCI D3hot.
What do you mean with that?
> Because the NVMe continues to work after s2idle and the symbol is
> rather subtle, so I suspect this is not platform or vendor specific.
> Is it possible to disable DMA for HMB NVMe on suspend?
Not in shipping products. The NVMe technical working group is working
on a way to do that, but it will take a while until that shows up in
products.
next prev parent reply other threads:[~2021-05-26 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210520033315.490584-1-koba.ko@canonical.com>
2021-05-25 7:44 ` [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss Christoph Hellwig
2021-05-25 16:49 ` Kai-Heng Feng
2021-05-25 20:14 ` Bjorn Helgaas
2021-05-26 2:02 ` Koba Ko
2021-05-26 2:49 ` Keith Busch
2021-05-26 12:11 ` Kai-Heng Feng
2021-05-26 12:59 ` Christoph Hellwig
2021-05-26 14:21 ` Kai-Heng Feng
2021-05-26 14:28 ` Christoph Hellwig [this message]
2021-05-26 14:47 ` Kai-Heng Feng
2021-05-26 15:06 ` Bjorn Helgaas
2021-05-26 16:24 ` Kai-Heng Feng
2021-05-27 11:40 ` Christoph Hellwig
2021-05-27 12:08 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526142809.GA32077@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=hjhansen2020@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=kbusch@kernel.org \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).