From: Clayton Casciato <majortomtosourcecontrol@gmail.com>
To: bhelgaas@google.com
Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-pci@vger.kernel.org,
Clayton Casciato <majortomtosourcecontrol@gmail.com>
Subject: [PATCH] acpi: pci_irq: Fixed a control flow style issue
Date: Sat, 12 Jun 2021 13:57:31 -0600 [thread overview]
Message-ID: <20210612195730.1069667-1-majortomtosourcecontrol@gmail.com> (raw)
Fixed coding style issue.
Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
---
drivers/acpi/pci_irq.c | 45 +++++++++++++++++++++---------------------
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index 08e15774fb9f..6eea3cf7b158 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -260,30 +260,29 @@ static int bridge_has_boot_interrupt_variant(struct pci_bus *bus)
static int acpi_reroute_boot_interrupt(struct pci_dev *dev,
struct acpi_prt_entry *entry)
{
- if (noioapicquirk || noioapicreroute) {
+ if (noioapicquirk || noioapicreroute)
return 0;
- } else {
- switch (bridge_has_boot_interrupt_variant(dev->bus)) {
- case 0:
- /* no rerouting necessary */
- return 0;
- case INTEL_IRQ_REROUTE_VARIANT:
- /*
- * Remap according to INTx routing table in 6700PXH
- * specs, intel order number 302628-002, section
- * 2.15.2. Other chipsets (80332, ...) have the same
- * mapping and are handled here as well.
- */
- dev_info(&dev->dev, "PCI IRQ %d -> rerouted to legacy "
- "IRQ %d\n", entry->index,
- (entry->index % 4) + 16);
- entry->index = (entry->index % 4) + 16;
- return 1;
- default:
- dev_warn(&dev->dev, "Cannot reroute IRQ %d to legacy "
- "IRQ: unknown mapping\n", entry->index);
- return -1;
- }
+
+ switch (bridge_has_boot_interrupt_variant(dev->bus)) {
+ case 0:
+ /* no rerouting necessary */
+ return 0;
+ case INTEL_IRQ_REROUTE_VARIANT:
+ /*
+ * Remap according to INTx routing table in 6700PXH
+ * specs, intel order number 302628-002, section
+ * 2.15.2. Other chipsets (80332, ...) have the same
+ * mapping and are handled here as well.
+ */
+ dev_info(&dev->dev, "PCI IRQ %d -> rerouted to legacy "
+ "IRQ %d\n", entry->index,
+ (entry->index % 4) + 16);
+ entry->index = (entry->index % 4) + 16;
+ return 1;
+ default:
+ dev_warn(&dev->dev, "Cannot reroute IRQ %d to legacy "
+ "IRQ: unknown mapping\n", entry->index);
+ return -1;
}
}
#endif /* CONFIG_X86_IO_APIC */
--
2.31.1
next reply other threads:[~2021-06-12 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 19:57 Clayton Casciato [this message]
2021-06-16 20:56 ` [PATCH] acpi: pci_irq: Fixed a control flow style issue Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612195730.1069667-1-majortomtosourcecontrol@gmail.com \
--to=majortomtosourcecontrol@gmail.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox