From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 12/16] docs: PCI: acpi-info.rst: replace some characters
Date: Wed, 16 Jun 2021 08:51:04 +0200 [thread overview]
Message-ID: <20210616085104.0477bd7b@coco.lan> (raw)
In-Reply-To: <20210519214731.GA262176@bjorn-Precision-5520>
Em Wed, 19 May 2021 16:47:31 -0500
Bjorn Helgaas <helgaas@kernel.org> escreveu:
> On Sun, May 16, 2021 at 12:18:29PM +0200, Mauro Carvalho Chehab wrote:
> > The conversion tools used during DocBook/LaTeX/html/Markdown->ReST
> > conversion and some cut-and-pasted text contain some characters that
> > aren't easily reachable on standard keyboards and/or could cause
> > troubles when parsed by the documentation build system.
> >
> > Replace the occurences of the following characters:
> >
> > - U+00a0 (' '): NO-BREAK SPACE
> > as it can cause lines being truncated on PDF output
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Apparently you missed
> https://lore.kernel.org/r/20210512212938.GA2516413@bjorn-Precision-5520
> where I pointed out a couple issues (3 spaces after period in first
> hunk, extra whitespace at end of "know about it." hunk) and added my
> ack.
>
> The subject line would be more useful as:
>
> docs: PCI: Replace non-breaking spaces to avoid PDF issues
>
> It's fine to defer those issues if you want,
Yeah, I opted to separate the changes into parts. This one is focused
on problematic chars that could lead into output issues.
Once those get merged, I'll submit a separate one with things like curly
commas and dashes, as a couple of maintainers seem to have different
opinions about that.
> but this is still:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Thanks!
Regards,
Mauro
next prev parent reply other threads:[~2021-06-16 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 10:18 [PATCH v3 00/16] Replace some bad characters on documents Mauro Carvalho Chehab
2021-05-16 10:18 ` [PATCH v3 12/16] docs: PCI: acpi-info.rst: replace some characters Mauro Carvalho Chehab
2021-05-19 21:47 ` Bjorn Helgaas
2021-06-16 6:51 ` Mauro Carvalho Chehab [this message]
2021-05-17 10:48 ` [PATCH v3 00/16] Replace some bad characters on documents David Woodhouse
2021-05-17 11:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616085104.0477bd7b@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).