From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: artpec6: Remove surplus break statement after return
Date: Thu, 1 Jul 2021 22:50:40 +0200 [thread overview]
Message-ID: <20210701205040.GA309322@rocinante> (raw)
In-Reply-To: <20210701195614.GA84355@bjorn-Precision-5520>
Hi Bjorn,
[...]
> According to
>
> $ git grep -n -A1 "return.*;" drivers/pci
>
> there's at least one more instance in
> drivers/pci/controller/dwc/pcie-designware-plat.c.
Nice find! I will send a patch shortly. Thank you!
[...]
> > pci->ep.ops = &pcie_ep_ops;
> >
> > return dw_pcie_ep_init(&pci->ep);
> > - break;
> > }
>
> Not related to your patch, but I'm not really a fan of the block here
> (needed because of the local "u32 val" declaration) because we end up
> with two close braces at the same indent level. I'd rather declare
> the variable at the top with the other local variables and dispense
> with the braces.
No problem! I will sent v2 to take care of this too in the same time.
Krzysztof
prev parent reply other threads:[~2021-07-01 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 19:16 [PATCH] PCI: artpec6: Remove surplus break statement after return Krzysztof Wilczyński
2021-07-01 19:56 ` Bjorn Helgaas
2021-07-01 20:50 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701205040.GA309322@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox