From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB23C07E99 for ; Mon, 12 Jul 2021 23:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0205A60FED for ; Mon, 12 Jul 2021 23:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233227AbhGLXM1 (ORCPT ); Mon, 12 Jul 2021 19:12:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54682 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232598AbhGLXM0 (ORCPT ); Mon, 12 Jul 2021 19:12:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626131377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ncUzG7oD+cRuBPSNikH54792RGrvr4Fe/3Hos8E3uks=; b=T9MbOaMrqioeCIHaPOkM8huVydSrj35IMGIsqlromCU0R26vxO3Pj+Zgtya+m+rLGCg5dK Dm2DpaTOAdxV93+nBWPUDBGZjY8quEl4ZM8Xno6Ek8+wVNhx0vfUgXUq7P1tQyB1GKjm0j 1Q56vTrCKaG6aAn7EUI/EejZV+UBN7s= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-573-1d9KQBTmNxKTXgNmTimHLA-1; Mon, 12 Jul 2021 19:09:36 -0400 X-MC-Unique: 1d9KQBTmNxKTXgNmTimHLA-1 Received: by mail-oi1-f198.google.com with SMTP id v16-20020aca48100000b0290240f6bdaf7dso12882095oia.14 for ; Mon, 12 Jul 2021 16:09:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ncUzG7oD+cRuBPSNikH54792RGrvr4Fe/3Hos8E3uks=; b=r2igXFE9xaT8KHTeyYhPZPVdIEl/ONvSo2mvAl19S/XSL1WL+hbtXsNBvwrthHXUPj Si+OG9iakOMa74e3e4w9turPtwNrF6jUud/RDYWLa6Z0PowKFWoOwffi3ZsJSl6O64/w v4HePUILBTpBCr5q3a6mxUpuen8nc2HSaapBjczAI9rCEw9p58oxMdisYMNh2tIu1ZnR YgW0WSn6QMhxAj5QnFm39NyLNOWdUBq3PYkforz2YiXHPiiIQZcpJ7XGoAqkkmBjeEuc yYzGhe5pzrYYGYgVVVCpNaj/HaAtucCvWX5RAy6142sp9SXU/4Lf7oHScU6Wu8adyISA GvIg== X-Gm-Message-State: AOAM530m0SSxbMB9ek9vIZJ8atFNeGjZK5rA1OWdnXvgEc9FkqbqBeqF 0sMuR/fefh1KCOlec/I7IDXipp4A1tVE6SnI9vcjbDjyD53bQbVU0IJ0OSCRfjQKxMy/xt/sGBa tysbB3Ds2A5e9UzjIuwAs X-Received: by 2002:a54:438f:: with SMTP id u15mr12421730oiv.107.1626131375434; Mon, 12 Jul 2021 16:09:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyf9OMLGHwJk5r+6cOuZb4j5x61M5JyJUaq4Ttbl9dxhduUH51eWgeVjM/8TiHf0dlltpaqyg== X-Received: by 2002:a54:438f:: with SMTP id u15mr12421718oiv.107.1626131375310; Mon, 12 Jul 2021 16:09:35 -0700 (PDT) Received: from redhat.com ([198.99.80.109]) by smtp.gmail.com with ESMTPSA id r24sm1026885otg.14.2021.07.12.16.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 16:09:35 -0700 (PDT) Date: Mon, 12 Jul 2021 17:09:34 -0600 From: Alex Williamson To: Amey Narkhede Cc: Bjorn Helgaas , Raphael Norwitz , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kw@linux.com, Shanker Donthineni , Sinan Kaya , Len Brown , "Rafael J . Wysocki" Subject: Re: [PATCH v10 6/8] PCI: Setup ACPI fwnode early and at the same time with OF Message-ID: <20210712170934.34666a1f.alex.williamson@redhat.com> In-Reply-To: <20210709123813.8700-7-ameynarkhede03@gmail.com> References: <20210709123813.8700-1-ameynarkhede03@gmail.com> <20210709123813.8700-7-ameynarkhede03@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 9 Jul 2021 18:08:11 +0530 Amey Narkhede wrote: > From: Shanker Donthineni > > The pci_dev objects are created through two mechanisms 1) during PCI > bus scan and 2) from I/O Virtualization. The fwnode in pci_dev object > is being set at different places depends on the type of firmware used, > device creation mechanism, and acpi_pci_bridge_d3() WAR. > > The software features which have a dependency on ACPI fwnode properties > and need to be handled before device_add() will not work. One use case, > the software has to check the existence of _RST method to support ACPI > based reset method. > > This patch does the two changes in order to provide fwnode consistently. > - Set ACPI and OF fwnodes from pci_setup_device(). > - Remove pci_set_acpi_fwnode() in acpi_pci_bridge_d3(). > > After this patch, ACPI/OF firmware properties are visible at the same > time during the early stage of pci_dev setup. And also call sites should > be able to use firmware agnostic functions device_property_xxx() for the > early PCI quirks in the future. > > Signed-off-by: Shanker Donthineni > --- > drivers/pci/pci-acpi.c | 1 - > drivers/pci/probe.c | 7 ++++--- > 2 files changed, 4 insertions(+), 4 deletions(-) Looks ok to me. Reviewed-by: Alex Williamson