From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] genirq/affinity: add helper of irq_affinity_calc_sets
Date: Mon, 19 Jul 2021 11:41:56 +0200 [thread overview]
Message-ID: <20210719094156.GB431@lst.de> (raw)
In-Reply-To: <20210715111827.569756-1-ming.lei@redhat.com>
On Thu, Jul 15, 2021 at 07:18:27PM +0800, Ming Lei wrote:
> + WARN_ON_ONCE(irq_affinity_calc_sets(1, affd));
Hiding actual functionality inside a WARN_ON is nasty.
> +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> +{
> + /*
> + * Simple invocations do not provide a calc_sets() callback. Install
> + * the generic one.
> + */
> + if (!affd->calc_sets)
> + affd->calc_sets = default_calc_sets;
> +
> + /* Recalculate the sets */
> + affd->calc_sets(affd, affvecs);
I'm not sure a function like this should have side effects. Either
we move the assign to an init function with a single caller, or do an
if / else here.
prev parent reply other threads:[~2021-07-19 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 11:18 [PATCH] genirq/affinity: add helper of irq_affinity_calc_sets Ming Lei
2021-07-15 14:27 ` Bjorn Helgaas
2021-07-16 2:10 ` Ming Lei
2021-07-19 9:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719094156.GB431@lst.de \
--to=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).