From: Bjorn Helgaas <helgaas@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
marek.vasut@gmail.com, linux-pci@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Wolfram Sang <wsa@the-dreams.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V6] PCI: rcar: Add L1 link state fix into data abort hook
Date: Mon, 19 Jul 2021 17:06:06 -0500 [thread overview]
Message-ID: <20210719220606.GA30209@bjorn-Precision-5520> (raw)
In-Reply-To: <20210719172340.vvtnddbli2vgxndi@pali>
On Mon, Jul 19, 2021 at 07:23:40PM +0200, Pali Rohár wrote:
> > On Sat, Jul 17, 2021 at 12:33:34PM -0500, Bjorn Helgaas wrote:
> > > - "The R-Car PCIe controller is capable of handling L0s/L1 link
> > > states." AFAICT every PCIe device is required to handle L0 and L1
> > > without software assistance. So saying R-Car is "capable" puts a
> > > better face on this than seems warranted.
> > >
> > > L0s doesn't seem relevant at all; at least it doesn't seem to play
> > > a role in the patch. There's no such thing as "returning to L0s"
> > > as mentioned in the comment below; L0s is only reachable from L0.
> > > Returns from L1 only go to L0 (PCIe r5.0, fig 5-1).
>
> IIRC from L1 you can only go to Recovery. And from L0s you go to L0 or
> Recovery. But I do not know what is or was changed in PCIe r5.0.
Yes. Per PCIe r5.0, fig 4-26, the LTSSM state diagram, that's still
the same. The overview in Fig 5-1 doesn't include Recovery, Detect,
and othef LTSSM states.
next prev parent reply other threads:[~2021-07-20 3:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 20:05 [PATCH V6] PCI: rcar: Add L1 link state fix into data abort hook marek.vasut
2021-05-17 7:39 ` Geert Uytterhoeven
2021-07-17 17:33 ` Bjorn Helgaas
2021-07-17 18:14 ` Marek Vasut
2021-07-19 8:59 ` Lorenzo Pieralisi
2021-07-19 15:38 ` Marek Vasut
2021-07-19 17:23 ` Pali Rohár
2021-07-19 18:39 ` Marek Vasut
2021-07-22 20:31 ` Pali Rohár
2021-07-19 22:06 ` Bjorn Helgaas [this message]
2021-07-27 16:11 ` Lorenzo Pieralisi
2021-07-27 16:16 ` Geert Uytterhoeven
2021-07-26 14:47 ` Geert Uytterhoeven
2021-07-26 17:49 ` Bjorn Helgaas
2021-07-27 16:32 ` Lorenzo Pieralisi
2021-08-05 18:30 ` Pali Rohár
2021-07-27 17:08 ` Marek Vasut
2021-08-04 11:06 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719220606.GA30209@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=pali@kernel.org \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox